Skip to content

Fix: HBO in icCurvesFromXml()#658

Merged
xsscx merged 1 commit intomasterfrom
issue-651
Mar 8, 2026
Merged

Fix: HBO in icCurvesFromXml()#658
xsscx merged 1 commit intomasterfrom
issue-651

Conversation

@ChrisCoxArt
Copy link
Contributor

Fixes #651

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner March 8, 2026 01:20
@xsscx xsscx self-assigned this Mar 8, 2026
@xsscx xsscx added PR Pull Request Review in Process Issue is being Reviewed by Maintainers Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process Issue is being Reviewed by Maintainers pending labels Mar 8, 2026
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer Review

2026-03-08 01:21:09 UTC

cd ~
mkdir pr-658
cd pr-658
git clone https://github.com/InternationalColorConsortium/iccDEV.git
cd iccDEV
git fetch origin pull/658/head:pr-658
git checkout pr-658
cd Build
export CXX=clang++ && export CXXFLAGS="-fsanitize=address,undefined -fno-omit-frame-pointer -g -O1 -fprofile-arcs -ftest-coverage" && export LDFLAGS="-fsanitize=address,undefined -fprofile-arcs" && cmake Cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_ASAN=ON -DENABLE_UBSAN=ON -DENABLE_COVERAGE=ON
make -j32
wget https://github.com/xsscx/fuzz/raw/refs/heads/master/xml/icc/hbo-icCurvesFromXml-IccTagXml_cpp-Line333.xml
ASAN_OPTIONS=print_scariness=1:halt_on_error=0 iccFromXml hbo-icCurvesFromXml-IccTagXml_cpp-Line333.xml foo.bar
...
git log --oneline --graph -1
* fa8ead4 (HEAD -> pr-658, origin/issue-651) check channel counts when reading CLUTs from XML
ASAN_OPTIONS=print_scariness=1:halt_on_error=0 Tools/IccFromXml/iccFromXml hbo-icCurvesFromXml-IccTagXml_cpp-Line333.xml foo.bar
Unable to Parse "lutAtoBType" (AToB0Tag) Tag on line 32

Unable to Parse 'hbo-icCurvesFromXml-IccTagXml_cpp-Line333.xml'

@xsscx xsscx changed the title check channel counts when reading CLUTs from XML Fix: HBO in icCurvesFromXml() Mar 8, 2026
@xsscx xsscx merged commit ca79ed0 into master Mar 8, 2026
27 checks passed
@xsscx xsscx added Merged Merged CVE Requested Maintainer indicates a CVE has been Requested and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Mar 8, 2026
@xsscx
Copy link
Member

xsscx commented Mar 9, 2026

GHSA-mv6h-vpcg-pwfx

@ChrisCoxArt ChrisCoxArt deleted the issue-651 branch March 15, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CVE Requested Maintainer indicates a CVE has been Requested Merged Merged PR Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HBO in icCurvesFromXml() at IccTagXml.cpp:3330

2 participants