-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Migrate tests from xunit to TUnit #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BenjaminMichaelis
wants to merge
3
commits into
main
Choose a base branch
from
bmichaelis/tunit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+324
−309
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,48 @@ | ||
| using EssentialCSharp.Web.Models; | ||
| using EssentialCSharp.Web.Services; | ||
| using Microsoft.Extensions.Configuration; | ||
| using EssentialCSharp.Web.Models; | ||
| using EssentialCSharp.Web.Services; | ||
| using Microsoft.Extensions.Configuration; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
|
|
||
| namespace EssentialCSharp.Web.Extensions.Tests.Integration; | ||
|
|
||
| public class CaptchaTests(CaptchaServiceProvider serviceProvider) : IClassFixture<CaptchaServiceProvider> | ||
| { | ||
| [Fact] | ||
| public async Task CaptchaService_Verify_Success() | ||
| { | ||
| ICaptchaService captchaService = serviceProvider.ServiceProvider.GetRequiredService<ICaptchaService>(); | ||
|
|
||
| // From https://docs.hcaptcha.com/#integration-testing-test-keys | ||
| string hCaptchaSecret = "0x0000000000000000000000000000000000000000"; | ||
| string hCaptchaToken = "10000000-aaaa-bbbb-cccc-000000000001"; | ||
| string hCaptchaSiteKey = "10000000-ffff-ffff-ffff-000000000001"; | ||
| HCaptchaResult? response = await captchaService.VerifyAsync(hCaptchaSecret, hCaptchaToken, hCaptchaSiteKey); | ||
|
|
||
| Assert.NotNull(response); | ||
| Assert.True(response.Success); | ||
| } | ||
| } | ||
|
|
||
| public class CaptchaServiceProvider | ||
| { | ||
| public ServiceProvider ServiceProvider { get; } = CreateServiceProvider(); | ||
| public static ServiceProvider CreateServiceProvider() | ||
| { | ||
| IServiceCollection services = new ServiceCollection(); | ||
|
|
||
| IConfigurationRoot configuration = new ConfigurationBuilder() | ||
| .SetBasePath(IntelliTect.Multitool.RepositoryPaths.GetDefaultRepoRoot()) | ||
| .AddJsonFile($"{nameof(EssentialCSharp)}.{nameof(Web)}/appsettings.json") | ||
| .Build(); | ||
| services.AddCaptchaService(configuration.GetSection(CaptchaOptions.CaptchaSender)); | ||
| // Add other necessary services here | ||
|
|
||
| return services.BuildServiceProvider(); | ||
| } | ||
| } | ||
| namespace EssentialCSharp.Web.Extensions.Tests.Integration; | ||
|
|
||
| [ClassDataSource<CaptchaServiceProvider>(Shared = SharedType.PerClass)] | ||
| public class CaptchaTests(CaptchaServiceProvider serviceProvider) | ||
| { | ||
| [Test] | ||
| public async Task CaptchaService_Verify_Success() | ||
| { | ||
| ICaptchaService captchaService = serviceProvider.ServiceProvider.GetRequiredService<ICaptchaService>(); | ||
|
|
||
| // From https://docs.hcaptcha.com/#integration-testing-test-keys | ||
| string hCaptchaSecret = "0x0000000000000000000000000000000000000000"; | ||
| string hCaptchaToken = "10000000-aaaa-bbbb-cccc-000000000001"; | ||
| string hCaptchaSiteKey = "10000000-ffff-ffff-ffff-000000000001"; | ||
| HCaptchaResult? response = await captchaService.VerifyAsync(hCaptchaSecret, hCaptchaToken, hCaptchaSiteKey); | ||
|
|
||
| await Assert.That(response).IsNotNull(); | ||
| await Assert.That(response.Success).IsTrue(); | ||
| } | ||
| } | ||
|
|
||
| public class CaptchaServiceProvider : IDisposable | ||
| { | ||
| public ServiceProvider ServiceProvider { get; } = CreateServiceProvider(); | ||
| public static ServiceProvider CreateServiceProvider() | ||
| { | ||
| IServiceCollection services = new ServiceCollection(); | ||
|
|
||
| IConfigurationRoot configuration = new ConfigurationBuilder() | ||
| .SetBasePath(IntelliTect.Multitool.RepositoryPaths.GetDefaultRepoRoot()) | ||
| .AddJsonFile($"{nameof(EssentialCSharp)}.{nameof(Web)}/appsettings.json") | ||
| .Build(); | ||
| services.AddCaptchaService(configuration.GetSection(CaptchaOptions.CaptchaSender)); | ||
| // Add other necessary services here | ||
|
|
||
| return services.BuildServiceProvider(); | ||
| } | ||
| public void Dispose() | ||
| { | ||
| ServiceProvider.Dispose(); | ||
| GC.SuppressFinalize(this); | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
responseisHCaptchaResult?and is dereferenced (response.Success) afterIsNotNull(). If TUnit’sIsNotNull()doesn’t inform nullable flow analysis, this will produce CS8602 and fail the build with warnings-as-errors. Useresponse!(or capture a non-null local) before accessing.Success.