Skip to content

feat: Add 2fa and notification#85

Merged
baillyjamy merged 8 commits intomainfrom
feat-2fa
Mar 26, 2026
Merged

feat: Add 2fa and notification#85
baillyjamy merged 8 commits intomainfrom
feat-2fa

Conversation

@baillyjamy
Copy link
Contributor

@baillyjamy baillyjamy commented Mar 26, 2026

Add 2fa bottomsheet
Add notifcation feature + channel + permission

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2026

PR Reviewer Guide 🔍

(Review updated until commit 9bfaa23)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Hardcoded Staging Environment

The API environment is hardcoded to a staging server (staging-authenticator.dev.infomaniak.ch) instead of using the production environment. This appears to be debug configuration that was accidentally committed. If released, the app would connect to staging servers instead of production, potentially causing authentication failures or data leakage to non-production infrastructure.

apiEnvironment = ApiEnvironment.Custom(host = "staging-authenticator.dev.infomaniak.ch"),
Breaking Database Schema Change

The isNotificationEnabled column has been removed from AppSettingsEntity without a corresponding Room migration. If the app has existing users with the previous schema (which included this column), the app will crash on upgrade with an IllegalStateException due to the schema mismatch. A migration from version 1 to 2 must be provided, or the database version must be incremented with a fallback destructive migration strategy.

data class AppSettingsEntity(
    @PrimaryKey val id: Long = 0,
    val isAppLockEnabled: Boolean = false,
    val theme: Theme = Theme.System,
)

@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@github-actions
Copy link
Contributor

Persistent review updated to latest commit 7f1c025

@LouisCAD LouisCAD self-requested a review March 26, 2026 14:35
@github-actions
Copy link
Contributor

Persistent review updated to latest commit 9bfaa23

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@baillyjamy baillyjamy merged commit 18d1b3d into main Mar 26, 2026
9 checks passed
@baillyjamy baillyjamy deleted the feat-2fa branch March 26, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants