feat: Migration of legacy accounts

[tevincent]

No description provided.

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit 20c0f23)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Hardcoded Staging Environment The AuthenticatorFacade.create() call hardcodes environment = ApiEnvironment.Staging. This appears to be debug code that should use a build configuration or environment variable to support production releases. If deployed as-is, all authentication requests will hit staging servers instead of production. environment = ApiEnvironment.Staging, Runtime Crash from TODO Line 234 contains TODO("Try to login with credentials and OTP (native login)") passed as a parameter to attemptMigration. The Kotlin TODO() function throws NotImplementedError, which will crash the app if this code path is executed during a migration scenario. attemptMigration(accountToMigrate, TODO("Try to login with credentials and OTP (native login)")) Singleton Database Lifecycle Issue getLegacyAccounts() closes the database in a finally block after reading. Since OTPUserDatabase is a singleton (via INSTANCE), subsequent calls to getInstance() will return the already-closed instance, causing crashes if the migration flow or any other code attempts to access legacy accounts again. Consider removing the close operation or using a non-singleton pattern if the database is truly only needed once. return withContext(Dispatchers.IO) { try { database.otpUserDao().getAllUsers().map { LegacyAccount( userId = it.userID, email = it.email, displayName = it.displayName, avatar = it.avatar, secret = it.secret ) } } finally { database.close() } }

[github-actions]

Persistent review updated to latest commit 20c0f23

[github-actions]

Suggestion: The API environment is hardcoded to Staging, which will cause production builds to use staging servers. Inject the environment based on build configuration (e.g., BuildConfig.DEBUG) or a configurable property to ensure production releases use the correct endpoint. [possible issue, importance: 9]

Suggested change

	return AuthenticatorFacade.create(
	environment = ApiEnvironment.Staging,
	userAgent = userAgent,
	clientId = BuildConfig.CLIENT_ID,
	crashReport = crashReport,
	tokenBridge = tokenBridge,
	)
	return AuthenticatorFacade.create(
	environment = if (BuildConfig.DEBUG) ApiEnvironment.Staging else ApiEnvironment.Production,
	userAgent = userAgent,
	clientId = BuildConfig.CLIENT_ID,
	crashReport = crashReport,
	tokenBridge = tokenBridge,
	)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
102 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud