-
Notifications
You must be signed in to change notification settings - Fork 20
BMDeep tutorial added #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
BMDeep tutorial added #95
Conversation
was stored with a wrong name
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@fedorov did we already talk about this? If not, maybe we should briefly in the Slim meeting later today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I admit I lost track of this PR... |
|
no problem, me too :D |
|
@DanielaSchacherer I pushed some minor changes, and also left some suggestion in the comments here: https://colab.research.google.com/drive/1kD_mEbfi1ozhyyS0WK9zl3vyKYMJJJjA?usp=sharing |
|
I took the feedback in and answered to your comments in the notebook linked above. I already changed the code to use ann_index, so let's not merge yet, but let me test as soon as ann_index is out :) |
|
@fedorov do you have any additional feedback? |
|
You rely on "monolayer" in SeriesDescription in one of the queries, which is not a good pattern. Why not use Search by unstructured data is not desirable, especially when the query can be resolved using structured data. client.fetch_index("ann_group_index")
# Select all annotation groups from ANN series whose SeriesDescription
# mentions "monolayer" in the bonemarrowwsi_pediatricleukemia collection
monolayer_ann_groups = client.sql_query("""
SELECT
ag.SeriesInstanceUID,
ag.AnnotationGroupNumber,
ag.AnnotationGroupUID,
ag.AnnotationGroupLabel,
ag.NumberOfAnnotations,
ag.GraphicType,
ag.AnnotationPropertyCategory_CodeMeaning,
ag.AnnotationPropertyType_CodeMeaning,
ai.referenced_SeriesInstanceUID
FROM ann_group_index ag
JOIN ann_index ai
ON ag.SeriesInstanceUID = ai.SeriesInstanceUID
JOIN index i
ON ag.SeriesInstanceUID = i.SeriesInstanceUID
WHERE i.collection_id = 'bonemarrowwsi_pediatricleukemia'
AND ag.AnnotationPropertyType_CodeMeaning = 'Selected region'
ORDER BY ag.SeriesInstanceUID, ag.AnnotationGroupNumber
""")
print(f"Found {len(monolayer_ann_groups)} annotation groups "
f"across {monolayer_ann_groups['SeriesInstanceUID'].nunique()} ANN series")
display(monolayer_ann_groups) |
|
Also note that |
|
I think similar comment applies further in the notebook where you deal with unlabeled cells. |
As discussed, I added the BMDeep tutorial. Happy for feedback! :)