Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 71.43% 71.45% +0.02%
==========================================
Files 81 81
Lines 4029 4029
==========================================
+ Hits 2878 2879 +1
+ Misses 1151 1150 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think tests are failing because ITensor/ITensors.jl#1709 isn't merged. |
Yes, though see my comment ITensor/ITensors.jl#1709 (comment) about how we should try to design that PR so it doesn't break ITensorNetworks.jl. |
|
@emstoudenmire can you remove the auto fermion update from this PR and just include the callback fix? |
|
I reverted the change to |
|
Just added the regression test and increased the version number |
This PR fixes two issues (can split if better):
updates the OpSum to TTN code to call the newpermfactorinterface of the auto fermion system, as updated in Optimization for fermion system ITensors.jl#1709dmrgandeigsolvefunctions