Skip to content

DMRG Callback#304

Merged
mtfishman merged 10 commits intomainfrom
MS_dmrg_callback
Mar 8, 2026
Merged

DMRG Callback#304
mtfishman merged 10 commits intomainfrom
MS_dmrg_callback

Conversation

@emstoudenmire
Copy link
Contributor

@emstoudenmire emstoudenmire commented Mar 6, 2026

This PR fixes two issues (can split if better):

  1. updates the OpSum to TTN code to call the new permfactor interface of the auto fermion system, as updated in Optimization for fermion system ITensors.jl#1709
  2. Allows passing a sweep_callback to the dmrg and eigsolve functions

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.45%. Comparing base (7e4c461) to head (5d3749c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   71.43%   71.45%   +0.02%     
==========================================
  Files          81       81              
  Lines        4029     4029              
==========================================
+ Hits         2878     2879       +1     
+ Misses       1151     1150       -1     
Flag Coverage Δ
docs 36.57% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emstoudenmire
Copy link
Contributor Author

I think tests are failing because ITensor/ITensors.jl#1709 isn't merged.

@mtfishman
Copy link
Member

I think tests are failing because ITensor/ITensors.jl#1709 isn't merged.

Yes, though see my comment ITensor/ITensors.jl#1709 (comment) about how we should try to design that PR so it doesn't break ITensorNetworks.jl.

@mtfishman
Copy link
Member

@emstoudenmire can you remove the auto fermion update from this PR and just include the callback fix?

@mtfishman
Copy link
Member

I reverted the change to compute_permfactor. @emstoudenmire can you add a regression test for this? Besides that I'm fine with merging this.

@mtfishman mtfishman changed the title DMRG Callback and Auto Fermion Update DMRG Callback Mar 8, 2026
@mtfishman mtfishman closed this Mar 8, 2026
@mtfishman mtfishman reopened this Mar 8, 2026
@emstoudenmire
Copy link
Contributor Author

Just added the regression test and increased the version number

@mtfishman mtfishman merged commit ba6f367 into main Mar 8, 2026
16 checks passed
@mtfishman mtfishman deleted the MS_dmrg_callback branch March 8, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants