Conversation
…d for verifiability
Noticed some stray Py2 style and some uncommon naming
…g-data-types into filewriter_ctrl
…pes into filewriter_ctrl
File-writer control changes
Update outdated/faulty code
Co-authored-by: Jonas Nilsson <mjc.nilsson@gmail.com>
Add deserialiser for ndarray
Removed 'required' constraint from reference_time field.
…gGroup/streaming-data-types into pu00_pulse_metadata
Contributor
|
i can't seem to actually comment on the file as github is struggling but i wonder whether we could/should use https://docs.rs/flatc-rust/latest/flatc_rust/ to generate the bindings (for python and/or rust?) this is what the digital muon pipeline repo does - https://github.com/ISISNeutronMuon/digital-muon-pipeline/blob/main/streaming-types/build.rs |
Member
Author
|
That's what I started with (removed in commit 56f669d ) - removed it because that approach still means consumers of the package need |
Contributor
|
nah makes sense - ignore my comment. |
Tom-Willemsen
force-pushed
the
packaging
branch
from
b4c137c to
c81d913
Compare
rerpha
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package rust & python utility libraries alongside our schema definitions.
Large number of commits is due to merging in the existing python utility library (previously
python-streaming-data-types).