Merged
Conversation
…types still need to add protocol-level and message-level handling Signed-off-by: Lance Drane <dranelt@ornl.gov>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
still need to namespace events Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
…rver Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Collaborator
marshallmcdonnell
left a comment
There was a problem hiding this comment.
Overall, looking great!
Agree, there is a lot here already and justifies 0.9.0 release.
Specifically, I like the new events by capability setup (ping @andrewfayres on that one!), MQTT support dropping 3 and adding 5, new core capabilities, and definitely the headers logic!
Issues:
- looks like CI caught some tests on specific version of python, copy-pasted the two failed tests below if that helps:
SKIPPED [1] tests/unit/test_schema_invalids.py:745: Python 3.11 does not allow dataclasses to be constructed in this improper format
FAILED tests/e2e/test_examples.py::test_example_4_service_to_service - subprocess.TimeoutExpired: Command '['/home/runner/work/python-sdk/python-sdk/.venv/bin/python', '-m', 'examples.4_service_to_service.example_client']' timed out after 60 seconds
FAILED tests/integration/test_service.py::test_call_user_function - TypeError: 'UserspaceMessageHeaders' object is not subscriptable
- Ruff linting caught a few errors as well
I'll launch a copilot review after those are fixed, just to see what it says (not required to address everything it might bring up)
Yet, merge whenever you feel ready.
I'll put requested changes but will readily approve after CI is green
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Collaborator
Author
|
I fixed the few remaining bugs in the tests, one of the tests caught an error with how external requests were being handled. Went ahead and merged, will be releasing 0.9.0 shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are enough changes here, and this fixes enough flaws with the original design, that I think we should go ahead and release this.
This makes considerable internal changes, and is best understood by observing the following issues. This does not change the public API by much, but it does change how events function.
This MR does NOT include:
(these features will come in a future release)
Closes #8 #13 #23 #24 #26 #29 #33 #40
TODOS BEFORE RELEASING 0.9.0
src/intersect_sdk/version.pybefore release