feat(translation-worker): add translation worker with argostranslate#8
Merged
winsomeglint merged 7 commits intomainfrom Mar 31, 2026
Merged
feat(translation-worker): add translation worker with argostranslate#8winsomeglint merged 7 commits intomainfrom
winsomeglint merged 7 commits intomainfrom
Conversation
winsomeglint
force-pushed
the
temporal-translation
branch
2 times, most recently
from
00907da to
3468b67
Compare
winsomeglint
force-pushed
the
temporal-translation
branch
4 times, most recently
from
c12bc74 to
efaa435
Compare
winsomeglint
force-pushed
the
temporal-translation
branch
from
efaa435 to
271c4c1
Compare
winsomeglint
changed the title
ClemDoum
reviewed
Mar 24, 2026
|
|
||
|
|
||
| # Temporal utils | ||
| async def async_batches( |
Contributor
There was a problem hiding this comment.
I feel like these ones could go in here: https://github.com/ICIJ/icij-python/tree/main/icij-common/icij_common
Since there are not datashare / temporal specific but more asyncio / iteratools related utils useful in all icij python projects
ClemDoum
requested changes
Mar 24, 2026
winsomeglint
changed the title
…ntrant across threads; switch from self._event_loop.run_until_complete to asyncio.run_coroutine_threadsafe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a translation worker under
translation-workerpowered byctranslate2andargostranslate.