Kirkman central db

[hhheath]

Drew is a maniac.

[Hodapp87]

A thought: If we're trying to restrict api/app to API endpoints, and there may be uses of the DB that are independent of this (e.g. a business logic layer, or another daemon that looks for queued tasks), might it make sense to put it one level higher in the hierarchy outside of app?

[hhheath]

@Hodapp87 is that something that currently happens? I have no issue with moving the DB connection a to a higher level, I just want to better understand what we currently have?

Could we have to connections, one for business logic or queued tasks, and one for api endpoints? I'm totally green to this, or even if that is a real question, only exploring options.

[Hodapp87]

It happens in the Perl in (I think) things like queue_runner.pl, and the logic for that may need to hang around. Flask is very request-oriented and likes to occupy the entire event loop, so it's plenty conceivable that for any sort of background task, we'd need a separate entry point distinct from api/app. Everything else in the module looks fine to me - except that it might make more sense to relocate so that it remains centralized.

[hhheath]

I just committed (as seen above) the code that I wrote last night.

I pulled the DB connection out of /app/ and made it available.

It pulls it's on config (inside of /db/config.py) but uses creds in app/creds.py

Not sure if we want to duplicate credentials, but that's how is now. Happy to move it anywhere we deem necessary.

[hhheath]

@Hodapp87 Thoughts now that I've moved the DB connection outside of /app/? I think we're ready to merge it!