fix(s3): Replace static S3 paths with hsg-shell config constant#3
Open
plutonik-a wants to merge 1 commit intomasterfrom
Open
fix(s3): Replace static S3 paths with hsg-shell config constant#3plutonik-a wants to merge 1 commit intomasterfrom
plutonik-a wants to merge 1 commit intomasterfrom
Conversation
* import hsg-shell config module * replace urls to S3 with $hsg-config:S3_URL * replace bucketname 'static.history.state.gov' with $hsg-config:S3_BUCKET Note: S3 references in file "modules/frus.xql" have been untouched, since the current syntax "//s3.amazonaws.com/static.history.state.gov" and the expected URL is unclear. ($frus:PAGEIMAGES-URL-PATH, $frus:PDF-URL-PATH)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$hsg-config:S3_BUCKET
Note: S3 references in file "modules/frus.xql" have been untouched,
since the current syntax "//s3.amazonaws.com/static.history.state.gov"
and the expected URL is unclear. ($frus:PAGEIMAGES-URL-PATH,
$frus:PDF-URL-PATH)