Merged
Conversation
I keep forgetting that type stripping doesn’t work with published modules...
cb1kenobi
reviewed
Mar 9, 2026
Contributor
Author
|
@cb1kenobi addressed everything! |
cb1kenobi
reviewed
Mar 9, 2026
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "$schema": "./node_modules/oxfmt/configuration_schema.json", | |||
There was a problem hiding this comment.
In case you're curious, here's rocksdb-js' oxfmt config: https://github.com/HarperFast/rocksdb-js/blob/main/.oxfmtrc.json. Most of the settings are the defaults and could have been omitted.
Contributor
Author
There was a problem hiding this comment.
I think I've got it down to the minimum in this repo -- are there other ones that you think should be the norm for Harper? Single quotes and tabs.
{
"$schema": "./node_modules/oxfmt/configuration_schema.json",
"singleQuote": true,
"useTabs": true
}
Contributor
Author
There was a problem hiding this comment.
In theory, I'll start applying this consistently across other repos I touch like Studio, Agent and create harper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mostly adds the workflows that we'll want, but it also formatted the code that I put together. Review whatever you feel like reviewing! Or just try it out on your project.
During dev, you'll want to git clone this repo, cd into it, and then
(npm link && cd ~/path-to-your-app && npm link @harperfast/schema-codegen).Then configure this in your app's config.yaml:
config.yaml:
and when you
harper dev ., it will generate stuff in those two files for you:globalTypes.d.ts:
types.ts: