Expand static types

[dawsontoth]

I did a few things here:

1. I fixed a bug I found in getIndexedValues
2. I fixed the schema description for shard in the config-root.schema.json
3. I added interfaces describing the methods and stuff we have on tables and resources, shuffling things around a little bit to facilitate that

Why? Well, it will more easily describe our tables and resources for consumers. I shifted the tables and databases to point people at these interfaces instead of at the return value of makeTable. These are a lot easier for IDEs, agents, and humans to read as a result. It will also let people guard their types when using static methods themselves.

Here's the question, though: what should be described in the interfaces for statics? What shouldn't be described, because its an internal implementation detail?

[kriszyp]

Lots of great stuff, thank you for working on this!

[kriszyp]

Are these all things we are exposing in our public interface, or things that we have declare internally for consistency? We certainly don't document these nor ever want users accessing most of these.

[dawsontoth]

We should only put stuff in that we want to expose, IMO

[kriszyp]

I am not sure I understand the different between the TableInterface and the TableStaticInterface. All the properties on TableInterface are statics, so not sure how it is less static than the other statics.

[dawsontoth]

Ah, yeah, I muddled things up there a bit.

[dawsontoth]

So the Table and the TableInterface weren't different -- I collapsed Table and TableInterface together, which is consistent with how we were using ResourceInterface.

TableStaticInterface, on the other hand, expresses the type that was being computed off of ReturnType<typeof makeTable>. It can be constructed, and when it does, it returns a TableInterface (just like ResourceInterface vs ResourceStaticInterface). I built it off of all of the static methods on the table class. The methods between the two are a bit different, as are the argument orders.

I think I need to take a pass through the CRUD methods for tables (which aren't static) to make sure they're accurately described in the interface, because we have a different order there vs what the Resource class expects. So that will be more updates for TableInterface.

[cb1kenobi]

Nice! Wish we had these types a long time ago! Couple of small nits that you can accept/ignore/punt.

[kriszyp]

Is this kinda still in draft? Do you want me to put together a list of desired exposed properties/methods on tables?

[kriszyp]

Above you are using ExtendedIterable, which is more correct, I think.

[dawsontoth]

@kriszyp yup, still in draft -- we need a status between draft and ready, "ready to be torn apart" ;D

[kriszyp]

I don't think any of these are table instance methods or properties except getExpiresAt() and getUpdatedTime().

[kriszyp]

I think we probably want to expose these properties:

• attributes
• createdTimeProperty
• databaseName
• expirationMS
• getResidencyById
• primaryKey
• replicate
• schemaDefined
• sealed
• tableName
• updatedTimeProperty

And methods:

• addAttributes
• coerceId
• getRecordCount
• getSize
• getNewId
• getStorageStats
• removeAttributes
• setTTLExpiration
• sourcedFrom