This repository was archived by the owner on Jun 21, 2019. It is now read-only.
Allow admins to enabled / disabled endpoints#168
Open
ASankaran wants to merge 17 commits intoHackIllinois:stagingfrom
Open
Allow admins to enabled / disabled endpoints#168ASankaran wants to merge 17 commits intoHackIllinois:stagingfrom
ASankaran wants to merge 17 commits intoHackIllinois:stagingfrom
Conversation
YashoSharma
suggested changes
Feb 9, 2018
Member
YashoSharma
left a comment
YashoSharma
left a comment
There was a problem hiding this comment.
I began reviewing this, but there are still console.log debug statements, let me know when this is ready for code review.
Additionally move this to a feature/EndpointAccess branch on Hackillinois/api
| @@ -0,0 +1,5 @@ | |||
| CREATE TABLE `endpoints` ( | |||
| `endpoint` VARCHAR(50) NOT NULL, | |||
Member
There was a problem hiding this comment.
Let's up this to 127 to leave a healthy margin
| @@ -0,0 +1,5 @@ | |||
| CREATE TABLE `endpoints` ( | |||
| `endpoint` VARCHAR(50) NOT NULL, | |||
| `enabled` BIT(1), | |||
Member
There was a problem hiding this comment.
Let's use TINYINT(1) for consistency with the rest of the schema
| @@ -0,0 +1,5 @@ | |||
| CREATE TABLE `endpoints` ( | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request implements the features described in #131.