Draft
Conversation
Should work for both TSMP-PDAF and GRACE-DA up to bugs
Have to be compared to `master` and refactored.
- `domain_def_clm_tws` from `mod_read_obs` for GRACE-DA - `domain_def_clm` from `enkf_clm_mod` as backward compatible default
``` common/read_enkfpar.c:158:3: warning: '/*' within block comment [-Wcomment] ```
``` mod_read_obs.F90(538): error #6580: Name in only-list does not exist or is not accessible. [CLMUPDATE_TWS] ``` Also added further arrays/variables from eCLM-developments
Errors such as the following otherwise appear: ``` mod_read_obs.F90(795): error #6580: Name in only-list does not exist or is not accessible. [LON1D] ```
``` eclm/enkf_clm_mod_5.F90(3798): error #5082: Syntax error, found '-' when expecting one of: <END-OF-STATEMENT> ; <IDENTIFIER> ```
``` eclm/enkf_clm_mod_5.F90(669): error #6496: There is more than one use-name for a local-name. [R8] ```
for now: duplicate definition of check-netCDF routine ``` eclm/enkf_clm_mod_5.F90(4383): error #7002: Error in opening the compiled module file. Check INCLUDE paths. [MOD_READ_OBS] ```
``` mod_read_obs.F90(654): error #6414: This PARAMETER constant name is invalid in this context. [VARNAME] ```
``` next_observation_pdaf.F90(72): error #6405: The same named entity from different modules and/or program units cannot be referenced. [DA_INTERVAL] ```
``` next_observation_pdaf.F90(74): error #6580: Name in only-list does not exist or is not accessible. [SET_AVERAGING_TO_ZERO] ```
``` eclm/enkf_clm_mod_5.F90(3796): error #5082: Syntax error, found '-' when expecting one of: <END-OF-STATEMENT> ; <IDENTIFIER> ```
``` mod_read_obs.F90(646): error #6832: This passed length character name has been used in an invalid context. [VARNAME] ```
``` mod_read_obs.F90(652): error #6404: This name does not have a type, and must have an explicit type. [CLMUPDATE_TWS] ```
``` init_dim_obs_pdaf.F90(102): error #6580: Name in only-list does not exist or is not accessible. [DOMAIN_DEF_CLM_TWS] ```
``` init_dim_obs_pdaf.F90(172): error #6418: This name has already been assigned a data type. [C] ```
``` init_dim_obs_pdaf.F90(1191): error #6404: This name does not have a type, and must have an explicit type. [DIM_OBS_F] ```
``` obs_op_pdaf.F90(63): error #6580: Name in only-list does not exist or is not accessible. [CRNS_FLAG] ```
``` obs_op_pdaf.F90(89): error #6580: Name in only-list does not exist or is not accessible. [INST_SUFFIX] ```
``` init_dim_obs_pdaf.F90(540): error #6404: This name does not have a type, and must have an explicit type. [CLMUPDATE_TWS] ```
``` init_obscovar_pdaf.F90(122): error #6404: This name does not have a type, and must have an explicit type. [POINT_OBS] ```
``` init_dim_l_pdaf.F90(92): error #6404: This name does not have a type, and must have an explicit type. [CLMUPDATE_TWS] ```
``` obs_op_f_pdaf.F90(126): error #6404: This name does not have a type, and must have an explicit type. [MYPE_WORLD] ```
``` init_dim_obs_l_pdaf.F90(76): error #6580: Name in only-list does not exist or is not accessible. [GRC] ```
``` wrapper_tsmp.c:(.text+0x186): undefined reference to `print_inc_clm' ```
``` obs_op_f_pdaf.F90(128): error #6404: This name does not have a type, and must have an explicit type. [CLMUPDATE_TWS] ```
May have been the reason testcases do not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains GRACE data assimilation, but is deprecated. All the functionality for GRACE data assimilation can be found in #26
@s7yoewer : Does anyone in Bonn still use this? If not, this PR will be cancelled and the branch removed.