Draft
Conversation
Error:
```
| 1
Error: Component ‘kmax’ at (1) is a PRIVATE component of
‘photo_params_type’
```
https://github.com/HPSCTerrSys/TSMP2/actions/runs/19573560213/job/56052817373
Generated with Claude Code Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First implementation of LAI-DA by @lstrebel.
Testing
Summary of PR: LAI Data Assimilation
This branch implements assimilation of Leaf Area Index (LAI) observations into eCLM (with BGC active).
Background
In eCLM with BGC, LAI is a diagnostic quantity derived from leaf carbon (
leafc) and plant-functional-type constants for specific leaf area (slatop,dsladlai) via theThornton & Zimmermann (2007)formula. Because LAI is not a direct model state variable, assimilation must operate on leafc (and the consistent leafn) rather than on LAI directly.New
enkfpf.parparametersCLM:update_laiCLM:update_lai_paramsMode 1 (
update_lai=1): the state vector holds one gridcell-averaged LAI per grid cell. A set function aggregates per-patch LAI fromleafc; after the PDAF update an inverse transformation distributes the updated LAI back to per-patchleafc/leafn.Mode 2 (
update_lai=2): the state vector holdsleafc,slatop, anddsladlaifor every patch (size: 3 × #patches). The mapping to observed gridcell LAI is performed insideobs_op_pdaf, using a nonlinear ensemble observation operator.Documentation
docs/users_guide/running_tsmp_pdaf/input_enkfpf.mddocs/users_guide/running_tsmp_pdaf/lai_da.md(new)