Early promote to FG service for active calls

[rahul-lohra]

Goal

Resolve ForegroundServiceDidNotStartInTimeException for ongoing calls

Implementation

Early promote to FG service for active calls

🎨 UI Changes

None

Testing

Simple call

Summary by CodeRabbit

• Bug Fixes
  • Improved call notification reliability by ensuring foreground service properly initiates whenever a notification is available, regardless of current call status. This resolves inconsistent notification delivery during calls.

[github-actions]

PR checklist ✅

All required conditions are satisfied:

• Title length is OK (or ignored by label).
• At least one pr: label exists.
• Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

[coderabbitai]

Walkthrough

The CallService notification logic was simplified by removing a conditional check that previously gated foreground service startup based on active call state. The service now unconditionally attempts to start foreground notifications when a setup notification is available, eliminating the prior state-dependent branching logic.

Changes

Cohort / File(s)	Summary
Service Notification Simplification stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt	Removed conditional logic that checked for active calls before starting foreground notifications. Service now directly starts foreground using setup notification when available, regardless of active call state. Associated logging and hasActiveCall control flow eliminated.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A simpler path the service now takes,
No branching doubts, no state it forsakes—
Notifications flow with clarity bright,
Foreground starts swift, without the fight!
~CodeRabbit's nibbling refactor delight

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The description covers Goal and Implementation sections with reasonable detail, but lacks several required sections like Testing explanation, UI Changes details, and Contributor Checklist items.	Expand Testing section with specific test cases and steps; complete the Contributor Checklist to verify all requirements are met.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: early promotion to foreground service for active calls to resolve timing exceptions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bugfix/rahullohra/early-promote-ongoing-call-fgs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt (1)

653-666: Function name no longer reflects its behavior.

The function promoteToFgServiceIfNoActiveCall now unconditionally promotes to foreground (when notification is available), but the name still implies it only does so when there's no active call. This could mislead future maintainers.

Consider renaming to better reflect the new behavior, e.g., promoteToFgServiceEarly or ensureForegroundStarted.

Suggested rename

-    private fun promoteToFgServiceIfNoActiveCall(
+    private fun promoteToFgServiceEarly(
         videoClient: StreamVideoClient,
         notificationId: Int,
         trigger: String,
     ) {
         videoClient.getSettingUpCallNotification()?.let { notification ->
             startForegroundWithServiceType(
                 notificationId,
                 notification,
                 trigger,
                 permissionManager.getServiceType(baseContext, trigger),
             )
         }
     }

Also update the call site at line 219:

promoteToFgServiceEarly(params.streamVideo, notificationId, params.trigger)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt`
around lines 653 - 666, Rename the misleading function
promoteToFgServiceIfNoActiveCall to a name that reflects unconditional promotion
(for example promoteToFgServiceEarly or ensureForegroundStarted) and update its
single call site where it's invoked as
promoteToFgServiceEarly(params.streamVideo, notificationId, params.trigger);
ensure the implementation (which uses
videoClient.getSettingUpCallNotification(), startForegroundWithServiceType(...),
permissionManager.getServiceType(baseContext, trigger)) remains unchanged but
the new name is used consistently across the file and any references are
updated.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt`:
- Around line 653-666: Rename the misleading function
promoteToFgServiceIfNoActiveCall to a name that reflects unconditional promotion
(for example promoteToFgServiceEarly or ensureForegroundStarted) and update its
single call site where it's invoked as
promoteToFgServiceEarly(params.streamVideo, notificationId, params.trigger);
ensure the implementation (which uses
videoClient.getSettingUpCallNotification(), startForegroundWithServiceType(...),
permissionManager.getServiceType(baseContext, trigger)) remains unchanged but
the new name is used consistently across the file and any references are
updated.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 075e38c5-9f85-48ec-81a0-96e306153aec

📥 Commits

Reviewing files that changed from the base of the PR and between 94feaea and afd52ba.

📒 Files selected for processing (1)

• stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt

[github-actions]

SDK Size Comparison 📏

SDK	Before	After	Difference	Status
stream-video-android-core	12.00 MB	12.00 MB	0.00 MB	🟢
stream-video-android-ui-xml	5.68 MB	5.68 MB	0.00 MB	🟢
stream-video-android-ui-compose	6.27 MB	6.27 MB	0.00 MB	🟢

[sonarqubecloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[stream-public-bot]

🚀 Available in v1.20.1