Skip to content

Update extensions to node18 environment#546

Open
pzmudzinski wants to merge 3 commits intoGetStream:mainfrom
pzmudzinski:update-to-node-18
Open

Update extensions to node18 environment#546
pzmudzinski wants to merge 3 commits intoGetStream:mainfrom
pzmudzinski:update-to-node-18

Conversation

@pzmudzinski
Copy link
Copy Markdown

No description provided.

@pzmudzinski pzmudzinski mentioned this pull request May 7, 2024
@skydoves
Copy link
Copy Markdown
Contributor

skydoves commented Jun 4, 2024

Hey @pzmudzinski, thank you for creating this PR! Would you also check out the CI build's testing?

@pzmudzinski
Copy link
Copy Markdown
Author

@skydoves Updated package-lock.json, let's try again.

@skydoves
Copy link
Copy Markdown
Contributor

skydoves commented Jun 5, 2024

@pzmudzinski Thanks for updating! It seems that the GitHub secrets on the CI were outdated, as the messages. I will update them to the new one, and please correct me if I'm wrong because I'm not an expertise on frontend 😄

@pzmudzinski
Copy link
Copy Markdown
Author

@skydoves I guess you need to re-run github workflow so we can check if it works now?

@skydoves
Copy link
Copy Markdown
Contributor

skydoves commented Jun 8, 2024

Hey @pzmudzinski, I think the GitHub CI configuration for the Firebase project is outdated or needs to be updated, and it will take some time. 😢 In the meantime, would you configure the secret keys and run the npm test with your Firebase project (not a production one) on your local device to double-check?

https://github.com/GetStream/stream-firebase-extensions/tree/main/integration-tests

@pzmudzinski
Copy link
Copy Markdown
Author

@skydoves It seems those tests are dependent on each other and data is not cleared correctly between tests suites. Most importantly - how this test is supposed to work? It's checking existing of some activity under user's feed but it's nowhere created in beforeAll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants