Fix test_participantAddsReactionWhileUserIsOffline flakey test by awaiting message sent confirmation.#6316
Draft
VelikovPetar wants to merge 1 commit intov7from
Draft
Fix test_participantAddsReactionWhileUserIsOffline flakey test by awaiting message sent confirmation.#6316VelikovPetar wants to merge 1 commit intov7from
test_participantAddsReactionWhileUserIsOffline flakey test by awaiting message sent confirmation.#6316VelikovPetar wants to merge 1 commit intov7from
Conversation
…iting message sent confirmation.
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
|
Contributor
SDK Size Comparison 📏
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Attempts to fix a flakey E2E test
Implementation
Await message to be sent before sending a reaction.
Testing
E2E test should not fail