Skip to content

Comments

fix: handle AN=0#89

Open
jsstevenson wants to merge 5 commits intomainfrom
fix/61-handle-an0
Open

fix: handle AN=0#89
jsstevenson wants to merge 5 commits intomainfrom
fix/61-handle-an0

Conversation

@jsstevenson
Copy link
Member

close #61

@jsstevenson jsstevenson requested a review from a team as a code owner February 13, 2026 18:45
@jsstevenson jsstevenson added the priority:low Low priority label Feb 13, 2026
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theferrit32 is reviewing this

@theferrit32
Copy link
Contributor

Code looks fine if we're okay with the total number of variations registered not always matching the number of variations in the VCF file if the VCF contains any with AN=0.

For the file tests/data/vcf/vcf_an_0.vcf there's a lot of content in this file that isn't really needed for the test case. Not technically a problem but it does make it harder for a human to look at the file and see what the relevant information is.

theferrit32
theferrit32 previously approved these changes Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:low Low priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ingest error when AN=0

3 participants