Fix FluidSlotWidget fluidChanged detect#90
Merged
serenibyss merged 1 commit intomasterfrom Jun 28, 2025
Merged
Conversation
serenibyss
approved these changes
Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is originally found because I'm working on an enhanced fluid tank in GT.
Because the fluid value is kept updated from
SWidgetUpdate, I think there must be something wrong.Then I found that in the method
FluidSlotWidget#fluidChanged,the
cachedvalue is also kept changing, whose fluid amount is jumping from x B to 2x B then back (eg 64B lava to 128B then 64B).The true cause of the amount changing is the line in
FluidTankLong#getFluidStack(), which the function is called inisFluidEqual:for example,
storedAmountis 64B, but thelastFluidAmountInStackis 0, then it makes the amount added to 128B.I'm not sure what does this
lastFluidAmountInStackdo, but removing it fixes this problem.