Skip to content

feat: Adding a fault stability analysis workflow#232

Merged
paloma-martinez merged 22 commits intomainfrom
pmartinez/feature/faultStabilityVisu
Mar 10, 2026
Merged

feat: Adding a fault stability analysis workflow#232
paloma-martinez merged 22 commits intomainfrom
pmartinez/feature/faultStabilityVisu

Conversation

@paloma-martinez
Copy link
Contributor

This PR will add a post-processing workflow to analyze the fault stability and plot various results.

@paloma-martinez paloma-martinez marked this pull request as ready for review March 5, 2026 10:56
@paloma-martinez paloma-martinez added the test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI label Mar 5, 2026
Copy link
Contributor

@RomainBaville RomainBaville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the job.
I made some suggestion but I have two additionnal global comment:
There is some caracter in the code that can lead to issues (greek letters, emoticon, arrows). To avoid that, you may change them.
In your code, some warning can be convert to error and the error managment can be updated (raise and not log error, use the CountVerbosityHandler ...)

Copy link
Contributor

@RomainBaville RomainBaville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the job.
I made some suggestion but I have two additionnal global comment:
There is some caracter in the code that can lead to issues (greek letters, emoticon, arrows). To avoid that, you may change them.
In your code, some warning can be convert to error and the error managment can be updated (raise and not log error, use the CountVerbosityHandler ...)

Copy link
Contributor

@RomainBaville RomainBaville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me. As your PR was already fat it is logical that you did not implement the tests but you may add an issue to implement them in the futur.

@paloma-martinez paloma-martinez merged commit 41cff65 into main Mar 10, 2026
56 checks passed
@paloma-martinez paloma-martinez deleted the pmartinez/feature/faultStabilityVisu branch March 10, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI type: feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants