feat: Split statistics components computation & output#3836
Open
feat: Split statistics components computation & output#3836
Conversation
…amandinehry/create-yaml-file-and-structure
…ttps://github.com/amandinehry/GEOS into feature/amandinehry/create-yaml-file-and-structure
…hry/create-yaml-file-and-structure
…rser.h modifications since no longer useful
…y/create-yaml-file-and-structure
…ttps://github.com/amandinehry/GEOS into feature/amandinehry/create-yaml-file-and-structure
…mandinehry/create-yaml-file-and-structure
…t-test + testing GEOS_ERROR
…unit test separation for multiple EXPECT_EXIT
tjb-ltk
reviewed
Mar 9, 2026
Contributor
There was a problem hiding this comment.
What is a PreparedTableLayout vs presumably an "non" PreparedTableLayout
Contributor
Author
There was a problem hiding this comment.
The TableLayout is the descriptor of the desired layout, and the PreparedTableLayout has precomputed data for optimizing further ascii formatting.
tjb-ltk
reviewed
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Why is this in the getTotalFluidMass function and not inside the region stats... could we get rid of the specializations at the getter level...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #3822
On top of PR : #3829
Planned refactor: The goal is to have a way to query statistics for solver (reservoir reference pressure for wells), with a clear separation with output statistics component.
The solution proposed here aims at giving a single data storage for each component needing statistics computation. In practices, the statistics are no longer recomputed for each convergence step, but only once, at start of each iteration (it gives the same result since the operation is read only).
To achieve these goals, the PR propose to separate each roles, instead of having everything in each
*PhaseStatisticsclass:RegionStatisticsclasses for resulting data storages at different levels:MeshLevel,StatsAggregatorclasses to compute & reduce the statistics to rank 0, can be instanciated as solver helpers (as done for wells in the PR),StatsTaskGroup, the user component to schedule flow statistics computation & output to log & CSV.Old stats data architecture (stats are sticked to regions, and shared by all components):
Proposed new way, with a clear storage for each aggregator instance:
Decoupling the storage of the
CellElementRegionwill help to provide a way of obtaining statistics from arbitrary mesh regions (defined by sets for instance).PR also propose to consolidate
testFlowStatisticsby also checking the total mass balance of the compositional cases.