Chunk getContractEvents into 500 block range#4
Merged
JoseMiguelHerrera merged 2 commits intotestfrom May 15, 2025
Merged
Conversation
Member
|
Can't believe they just changed this. How often were you running the lambda function? 5 mins? I guess we could speed it up by 4 to get around this, but chunking is defs the proper solution. Reviewing |
JoseMiguelHerrera
approved these changes
May 15, 2025
Member
JoseMiguelHerrera
left a comment
There was a problem hiding this comment.
Looks good. I ran a small unit test of the chunking logic and it separates things as expected. Good addition, as it makes us resilient to future block range limits. I guess the only thing that could be added is if the limit could be gotten via API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alchemy is limiting fetching block to ranges of 500. Implemented chunking to adhere to this restriction.