Open
Conversation
asfernandes
reviewed
Jul 14, 2025
src/common/IntlParametersBlock.h
Outdated
| TagType checkTag(UCHAR tag, const char** tagName); | ||
| UCHAR getUtf8Tag(); | ||
|
|
||
| ~IntlSpb() override = default; |
Member
There was a problem hiding this comment.
The destructors with override = default should not be needed.
Author
There was a problem hiding this comment.
And it really is. I checked and realized that they are optional. The main thing is to have a virtual destructor in the base class. I will fix this code soon. Thanks for the review.
asfernandes
reviewed
Jul 16, 2025
| #ifdef HAVE_PTHREAD_CANCEL | ||
| int dummy; // We do not want to know old cancel type | ||
| state = pthread_setcanceltype(PTHREAD_CANCEL_ASYNCHRONOUS, &dummy); | ||
| state = pthread_setcanceltype(PTHREAD_CANCEL_DEFERRED, &dummy); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction of some warnings of the static analyzer clang-tidy and clangsa.