fix: resolve Phosphor icons with comma-separated IcoMoon aliases#2
Open
NicolasDrapier wants to merge 1 commit intoFerrisMind:mainfrom
Open
fix: resolve Phosphor icons with comma-separated IcoMoon aliases#2NicolasDrapier wants to merge 1 commit intoFerrisMind:mainfrom
NicolasDrapier wants to merge 1 commit intoFerrisMind:mainfrom
Conversation
The IcoMoon selection.json files used by Phosphor store aliases as comma-separated names (e.g., "folder-open, folder-notch-open"). load_icomoon_selection() passed the raw name to normalize_kebab(), which replaced the comma+space with a hyphen, producing mangled names like "folder-open-folder-notch-open" instead of "folder-open". Split on comma and take only the primary name before normalizing. Fixes 18 base icons across 6 style variants (~104 entries).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_icomoon_selection()folder-openare registered asfolder-open-folder-notch-openand cannot be resolved by their canonical nameRoot cause
The Phosphor icon pack uses IcoMoon
selection.jsonfiles where icons with aliases store multiple names comma-separated:load_icomoon_selection()passes this raw value tonormalize_kebab(), which replaces the,with-, producingfolder-open-folder-notch-open.Fix
Split on comma and take the primary name before normalizing (
scripts/map_gen.py):Affected icons (18 base icons × 6 style variants)
folder-openfolder-open-folder-notch-openfolder-plusfolder-plus-folder-notch-plusfolder-minusfolder-minus-folder-notch-minusfile-dashedfile-dashed-file-dottedfile-magnifying-glassfile-magnifying-glass-file-searchpulsepulse-activityinfinityinfinity-lemniscateseal-checkseal-check-circle-wavy-check