Conversation
TaylerUva
left a comment
TaylerUva
left a comment
There was a problem hiding this comment.
Lets remove pivot from places since its redundant
There was a problem hiding this comment.
Pull Request Overview
This PR implements turret subsystem functionality by adding motor control for ball shooter, turret pivot, and hood mechanisms.
- Added Rotors subsystem with ball shooter motor control
- Added Motion subsystem with turret pivot and hood angle control using MotionMagic
- Configured motor parameters including PID values, soft limits, and current limits
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| Rotors.java | Implements ball shooter motor control with velocity monitoring |
| Motion.java | Implements turret pivot and hood angle control with position tracking and coast/brake mode switching |
| ConstRotors.java | Defines TalonFX configuration for ball shooter motor |
| ConstMotion.java | Defines TalonFX configurations for turret and hood motors |
| RobotMap.java | Adds CAN IDs for ball shooter, turret pivot, and hood motors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…turret and hood configurations
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.