Conversation
…ed_rules param Co-authored-by: admdly <2807620+admdly@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix class naming convention and translation checks
Fix class naming, translation check bug, missing disabled_rules param, and PEP 8 style
Mar 17, 2026
admdly
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several bugs and style issues in
check.pyincluding a logic bug causing translation strings to never actually be checked.Changes
process()was callingdoCheck(entry.msgid)for both source and translation checks — translations were never actually checked. Fixed todoCheck(entry.msgstr).disabled_ruleswas defined inPoChecker.__init__and wired intoLanguageToolconfig, but never passed frommain(). Addeddisabled_rules=config["disabledRules"]to the constructor call.poChecker→PoCheckerto follow Python PascalCase convention.isIssueValid—# Checks an issue against the→# Checks an issue against the custom dictionary to decide if it should be ignored.self.totalIssues+=1→self.totalIssues += 1(PEP 8).Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.