Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
admdly
changed the title
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
api-worker | 18b5533 | Commit Preview URL Branch Preview URL |
Mar 17 2026, 12:58 PM |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Cloudflare D1 test mock to address code-quality findings and make the mock’s behavior more robust/accurate when parsing versions and reporting mutation metadata.
Changes:
- Make semantic version comparison more defensive by safely parsing numeric parts.
- Normalize bound
idvalues to strings in one query path (WHERE id = ?) to improve matching. - Report DELETE “changes”/“rows_written” based on the actual number of deleted rows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
134
to
136
| if (query.includes("WHERE id = ?")) { | ||
| const id = params[0]; | ||
| const id = String(params[0]); | ||
| const alert = this.alerts.find((a) => a.id === id); |
Comment on lines
215
to
+219
| const id = params[0] as string; | ||
| const initialLength = this.alerts.length; | ||
| this.alerts = this.alerts.filter((a) => a.id !== id); | ||
| const wasDeleted = this.alerts.length < initialLength; | ||
| const deletedCount = initialLength - this.alerts.length; | ||
| const wasDeleted = deletedCount > 0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies 3/4 suggestions from code quality AI findings. 1 suggestion was skipped to avoid creating conflicts.