Open
Conversation
Contributor
Author
|
@codex review |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 1e1a1a94..86e3711a 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -954,17 +954,17 @@ const translations: TranslationDeepObject<typeof en> = {
ctaFix: 'Beheben',
fixCompanyCardConnection: {
title: ({feedName}: {feedName: string}) => (feedName ? `${feedName}-Firmenkartenverbindung reparieren` : 'Firmenkarte reparieren Verbindung der Firmenkarte reparieren'),
- defaultSubtitle: 'Workspace > Unternehmenskarten',
+ defaultSubtitle: 'Arbeitsbereich',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Unternehmenskarten`,
},
fixAccountingConnection: {
title: ({integrationName}: {integrationName: string}) => `${integrationName}-Verbindung reparieren`,
- defaultSubtitle: 'Arbeitsbereich > Buchhaltung',
+ defaultSubtitle: 'Arbeitsbereich',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Buchhaltung`,
},
fixPersonalCardConnection: {
title: ({cardName}: {cardName?: string}) => (cardName ? `Verbindung der persönlichen Karte ${cardName} reparieren` : 'Verbindung der persönlichen Karte reparieren'),
- subtitle: 'Wallet > Zugewiesene Karten',
+ subtitle: 'Wallet',
},
},
assignedCards: 'Zugewiesene Karten',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 2ec90e5c..11eefa0e 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -957,17 +957,17 @@ const translations: TranslationDeepObject<typeof en> = {
ctaFix: 'Corriger',
fixCompanyCardConnection: {
title: ({feedName}: {feedName: string}) => (feedName ? `Corriger la connexion de la carte d'entreprise ${feedName}` : 'Corriger la connexion de la carte entreprise'),
- defaultSubtitle: 'Espace de travail > Cartes d’entreprise',
+ defaultSubtitle: 'Espace de travail',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Cartes d'entreprise`,
},
fixAccountingConnection: {
title: ({integrationName}: {integrationName: string}) => `Corriger la connexion ${integrationName}`,
- defaultSubtitle: 'Espace de travail > Comptabilité',
+ defaultSubtitle: 'Espace de travail',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Comptabilité`,
},
fixPersonalCardConnection: {
title: ({cardName}: {cardName?: string}) => (cardName ? `Réparer la connexion de la carte personnelle ${cardName}` : 'Corriger la connexion de la carte personnelle'),
- subtitle: 'Portefeuille > Cartes assignées',
+ subtitle: 'Portefeuille',
},
},
assignedCards: 'Cartes assignées',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index cc8db792..62751213 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -953,17 +953,17 @@ const translations: TranslationDeepObject<typeof en> = {
ctaFix: 'Correggi',
fixCompanyCardConnection: {
title: ({feedName}: {feedName: string}) => (feedName ? `Correggi la connessione della carta aziendale ${feedName}` : 'Correggi connessione carta aziendale'),
- defaultSubtitle: 'Spazio di lavoro > Carte aziendali',
+ defaultSubtitle: 'Area di lavoro',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Carte aziendali`,
},
fixAccountingConnection: {
title: ({integrationName}: {integrationName: string}) => `Correggi connessione ${integrationName}`,
- defaultSubtitle: 'Spazio di lavoro > Contabilità',
+ defaultSubtitle: 'Area di lavoro',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Contabilità`,
},
fixPersonalCardConnection: {
title: ({cardName}: {cardName?: string}) => (cardName ? `Correggi la connessione della carta personale ${cardName}` : 'Correggi connessione carta personale'),
- subtitle: 'Portafoglio > Carte assegnate',
+ subtitle: 'Portafoglio',
},
},
assignedCards: 'Carte assegnate',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 150a0fbc..2b21505d 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -948,18 +948,15 @@ const translations: TranslationDeepObject<typeof en> = {
ctaFix: '修正',
fixCompanyCardConnection: {
title: ({feedName}: {feedName: string}) => (feedName ? `${feedName} 会社カード接続を修正` : '法人クレジットカードの接続を修正'),
- defaultSubtitle: 'ワークスペース > 会社カード',
+ defaultSubtitle: 'ワークスペース',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > 会社カード`,
},
fixAccountingConnection: {
title: ({integrationName}: {integrationName: string}) => `${integrationName} 接続を修正`,
- defaultSubtitle: 'ワークスペース > 会計',
+ defaultSubtitle: 'ワークスペース',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > 会計`,
},
- fixPersonalCardConnection: {
- title: ({cardName}: {cardName?: string}) => (cardName ? `${cardName}個人カードの接続を修正` : '個人カードの連携を修正'),
- subtitle: 'ウォレット > 割り当てられたカード',
- },
+ fixPersonalCardConnection: {title: ({cardName}: {cardName?: string}) => (cardName ? `${cardName}個人カードの接続を修正` : '個人カードの連携を修正'), subtitle: 'ウォレット'},
},
assignedCards: '割り当て済みカード',
assignedCardsRemaining: ({amount}: {amount: string}) => `残額：${amount}`,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 1415e133..46568ac6 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -952,17 +952,17 @@ const translations: TranslationDeepObject<typeof en> = {
ctaFix: 'Repareren',
fixCompanyCardConnection: {
title: ({feedName}: {feedName: string}) => (feedName ? `Verbinding bedrijfskaart ${feedName} herstellen` : 'Verbinding van bedrijfskaart repareren'),
- defaultSubtitle: 'Werkruimte > Bedrijfspassen',
+ defaultSubtitle: 'Werkruimte',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Bedrijfspassen`,
},
fixAccountingConnection: {
title: ({integrationName}: {integrationName: string}) => `Verbinding met ${integrationName} repareren`,
- defaultSubtitle: 'Werkruimte > Boekhouding',
+ defaultSubtitle: 'Werkruimte',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Boekhouding`,
},
fixPersonalCardConnection: {
title: ({cardName}: {cardName?: string}) => (cardName ? `Verbinding van persoonlijke kaart ${cardName} herstellen` : 'Verbinding persoonlijke kaart herstellen'),
- subtitle: 'Wallet > Toegewezen kaarten',
+ subtitle: 'Portemonnee',
},
},
assignedCards: 'Toegewezen kaarten',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 9dec059d..516a09cb 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -953,17 +953,17 @@ const translations: TranslationDeepObject<typeof en> = {
ctaFix: 'Napraw',
fixCompanyCardConnection: {
title: ({feedName}: {feedName: string}) => (feedName ? `Napraw połączenie karty firmowej ${feedName}` : 'Napraw połączenie karty firmowej'),
- defaultSubtitle: 'Workspace > Karty firmowe',
+ defaultSubtitle: 'Obszar roboczy',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Karty firmowe`,
},
fixAccountingConnection: {
title: ({integrationName}: {integrationName: string}) => `Napraw połączenie ${integrationName}`,
- defaultSubtitle: 'Przestrzeń robocza > Księgowość',
+ defaultSubtitle: 'Obszar roboczy',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Księgowość`,
},
fixPersonalCardConnection: {
title: ({cardName}: {cardName?: string}) => (cardName ? `Napraw połączenie z prywatną kartą ${cardName}` : 'Napraw połączenie karty prywatnej'),
- subtitle: 'Portfel > Przypisane karty',
+ subtitle: 'Portfel',
},
},
assignedCards: 'Przypisane karty',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 96bee03e..95aea9c4 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -951,17 +951,17 @@ const translations: TranslationDeepObject<typeof en> = {
ctaFix: 'Corrigir',
fixCompanyCardConnection: {
title: ({feedName}: {feedName: string}) => (feedName ? `Corrigir conexão do cartão corporativo ${feedName}` : 'Corrigir conexão do cartão corporativo'),
- defaultSubtitle: 'Área de trabalho > Cartões corporativos',
+ defaultSubtitle: 'Espaço de trabalho',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Cartões corporativos`,
},
fixAccountingConnection: {
title: ({integrationName}: {integrationName: string}) => `Corrigir conexão com ${integrationName}`,
- defaultSubtitle: 'Espaço de trabalho > Contabilidade',
+ defaultSubtitle: 'Espaço de trabalho',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Contabilidade`,
},
fixPersonalCardConnection: {
title: ({cardName}: {cardName?: string}) => (cardName ? `Corrigir conexão do cartão pessoal ${cardName}` : 'Corrigir conexão do cartão pessoal'),
- subtitle: 'Carteira > Cartões atribuídos',
+ subtitle: 'Carteira',
},
},
assignedCards: 'Cartões atribuídos',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index b45ddc73..ca4518b3 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -938,13 +938,13 @@ const translations: TranslationDeepObject<typeof en> = {
ctaFix: '修复',
fixCompanyCardConnection: {
title: ({feedName}: {feedName: string}) => (feedName ? `修复 ${feedName} 公司卡连接` : '修复公司卡连接'),
- defaultSubtitle: '工作区 > 公司卡片',
+ defaultSubtitle: '工作区',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > 公司卡片`,
},
- fixPersonalCardConnection: {title: ({cardName}: {cardName?: string}) => (cardName ? `修复 ${cardName} 个人卡连接` : '修复个人银行卡连接'), subtitle: '钱包 > 已分配的卡片'},
+ fixPersonalCardConnection: {title: ({cardName}: {cardName?: string}) => (cardName ? `修复 ${cardName} 个人卡连接` : '修复个人银行卡连接'), subtitle: '钱包'},
fixAccountingConnection: {
title: ({integrationName}: {integrationName: string}) => `修复 ${integrationName} 连接`,
- defaultSubtitle: '工作区 > 会计',
+ defaultSubtitle: '工作区',
subtitle: ({policyName}: {policyName: string}) => `${policyName} > 会计`,
},
},
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Contributor
|
@grgia Do we need to confirm the |
Contributor
|
Code review for PR #83333: Issues Found1. Inconsistent subtitle changes across languages (Major)In // en.ts / es.ts (AFTER this PR)
subtitle: ({policyName}: {policyName: string}) => policyName,However, in all other 8 language files (de, fr, it, ja, nl, pl, pt-BR, zh-hans), the // de.ts (unchanged by this PR)
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Unternehmenskarten`,
// fr.ts (unchanged)
subtitle: ({policyName}: {policyName: string}) => `${policyName} > Cartes d'entreprise`,
// ... same pattern in it, ja, nl, pl, pt-BR, zh-hansSince Affected lines (subtitle functions that need updating):
2. Formatting inconsistency in ja.ts (Minor)The // ja.ts (after this PR) - single line
fixPersonalCardConnection: {title: ({cardName}: {cardName?: string}) => ..., subtitle: 'ウォレット'},
// All other files - multi-line
fixPersonalCardConnection: {
title: ({cardName}: {cardName?: string}) => ...,
subtitle: 'Wallet',
},This should stay in multi-line format for consistency. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c14efdce4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+957
to
958
| defaultSubtitle: 'Arbeitsbereich', | ||
| subtitle: ({policyName}: {policyName: string}) => `${policyName} > Unternehmenskarten`, |
There was a problem hiding this comment.
This hunk updates defaultSubtitle to plain workspace text, but the subtitle callback in this locale still appends > …, so users with a policy name continue to see the old breadcrumb-style copy (for example, Acme > Unternehmenskarten) instead of just the workspace name; the same partial update pattern appears in other non-EN/ES files (fr.ts, it.ts, ja.ts, nl.ts, pl.ts, pt-BR.ts, zh-hans.ts) for both company-card and accounting subtitles, making the new copy inconsistent by locale.
Useful? React with 👍 / 👎.
melvin-bot
bot
requested review from
heyjennahay
and removed request for
a team
JmillsExpensify
approved these changes
Feb 25, 2026
Contributor
JmillsExpensify
left a comment
JmillsExpensify
left a comment
There was a problem hiding this comment.
Approving these changes for product since I was part of the earlier discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Minor copy change
Fixed Issues
$ #83260
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Verify that no errors appear in the JS console
QA Steps
cards"
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari