Provide necessary debug infromation in non-verbose test runs.#181
Merged
furtib merged 1 commit intoEricsson:mainfrom Feb 4, 2026
Merged
Provide necessary debug infromation in non-verbose test runs.#181furtib merged 1 commit intoEricsson:mainfrom
furtib merged 1 commit intoEricsson:mainfrom
Conversation
adf52e3 to
801c4ee
Compare
801c4ee to
8b0cb91
Compare
Szelethus
approved these changes
Feb 3, 2026
Contributor
Szelethus
left a comment
There was a problem hiding this comment.
I get the point, I'm just wondering if this is the way to do it -- will we always remember to add stderr as a third parameter? Can we just unconditionally print stderr from run_command()? Pytest actually handles output capturing rather elegantly. Though I'm not sure how much it'd litter the output for @nettle who IIRC doesn't use pytest (or not in every environment he tests in).
Still, the change as it stands is an improvement, once we put the effort into it, I suppose there is no reason not to accept it.
Contributor
Author
|
The idea behind #176 is to show the test author that they need to pass stderr as a 3rd parameter. |
8b0cb91 to
2c57018
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
I want to be able to get enough information without having to scroll through pages of logs.
By default, pytest hides the current logs. I need to pass --log-cli-level=DEBUG to each run, to see them.
What:
Addresses:
none