Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf884448e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
Addressed the review’s only actionable item (reverse-quote limit handling) and resolved the inline thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Description
Context
Asana: "exch: Swap - Xgram Support" (P1). This branch reapplies the plugin work from #405 so the exchange engine can serve the Xgram team with the new swap flow and mappings.
Changes
Original PR
xgramplugin insrc/index.ts, include its synchronizer inscripts/allSynchronizers.ts, and add the mapping source plus generated file so EdgeCurrencyPluginIds map to Xgram network codes.src/swap/central/xgram.tsto compose the Xgram API calls, assemble swap estimates, handle memos/mapping metadata, and feed the swap engine usableEdgeSpendInfo.Additional changes
ccyAmountlimit strings, producing the correctSwapBelowLimitError/SwapAboveLimitError, and recognizing literalerrorresponses via the newasXgramStringError.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
None
Requirements
If you have made any visual changes to the GUI. Make sure you have: