Open
Conversation
paullinator
force-pushed
the
paul/intercambio
branch
from
edb8e6e to
46e2897
Compare
Member
Author
|
@CriptointercambioDev Please look at my fixup commit. Also, the original PR is missing some proper error handling. You need to properly detect when the requested amount is above or below the limit and return the min/max amount accordingly using the SwapAboveLimitError or SwapBelowLimitError. As well, if there are any georestriction, return the SwapPermissionError. See https://github.com/EdgeApp/edge-exchange-plugins/blob/1396f800bc11db2fa918a4af0af07826bfa6de5a/src/swap/sideshift.js for examples Also, the code/API doesn't properly handle the case when a user is specifying the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.