chore: Remove node version requirements from package.json#1002
Merged
frankieyan merged 2 commits intomainfrom Jan 26, 2026
Merged
chore: Remove node version requirements from package.json#1002frankieyan merged 2 commits intomainfrom
frankieyan merged 2 commits intomainfrom
Conversation
Remove the `engines` field that required Node.js ^22.22.0 and npm ^10.9.2. This allows consumers to install `@doist/reactist` regardless of their Node.js version, since it's a client-side library that runs in the browser. The `engines` field was added to support `@doist/react-compiler-tracker` (a dev dependency), not for any runtime requirements. Development is still protected by the `.node-version` file and CI workflows. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
The changes in this pull request correctly remove the engines field from package.json and update @doist/react-compiler-tracker to version 2.1.2, which in turn relaxes its Node.js engine requirement. All modifications align with the stated goal of allowing consumers to install the library regardless of their Node.js version, as it's a client-side library. The changes are consistent across package.json and package-lock.json.
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
enginesfield that required Node.js ^22.22.0 and npm ^10.9.2. This allows consumers to install@doist/reactistregardless of their Node.js version, since it's a client-side library that runs in the browser.The
enginesfield was added to support@doist/react-compiler-tracker(a dev dependency), not for any runtime requirements. Development is still protected by the.node-versionfile and CI workflows.Also updates
@doist/react-compiler-trackerto 2.1.2, which relaxes its Node.js engine requirement to support Node 20.🤖 Generated with Claude Code