Refactor build script to use bash arrays instead of string concatenation#3
Merged
miragecentury merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
…spaces Labels like org.opencontainers.image.description="Python GitHub Runner" contain spaces. Using unquoted string variables caused word-splitting when passed to buildah, resulting in "accepts at most 1 arg(s), received 13". Switch to bash arrays with proper quoting so values with spaces are passed as single arguments. https://claude.ai/code/session_01WtJC749bMVKy7Xxr5P2WD7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the Docker build script in the release workflow to use bash arrays for constructing build arguments and labels instead of string concatenation. This improves code robustness and eliminates the need for shellcheck directives.
Key Changes
BUILD_ARGSfrom a string variable to an array, usingyqwith process substitution for cleaner iterationLABELSfrom a string variable to an array, appending label entries with proper quotingbuildah buildcommand to use array expansion syntax ("${BUILD_ARGS[@]}"and"${LABELS[@]}") instead of unquoted variable expansionshellcheck disable=SC2086comment as it's no longer needed with proper array handlingImplementation Details
+=operator for appending elements, which is more idiomatic than string concatenationhttps://claude.ai/code/session_01WtJC749bMVKy7Xxr5P2WD7