Fix multi-line TAP failure messages truncated by over-eager trimws()#20
Merged
smasongarrison merged 4 commits intomainfrom Mar 23, 2026
Merged
Fix multi-line TAP failure messages truncated by over-eager trimws()#20smasongarrison merged 4 commits intomainfrom
smasongarrison merged 4 commits intomainfrom
Conversation
…messages - Store tap_lines without trimws() so indentation is retained - Update grep/sub patterns to match indented YAML message keys - Strip YAML block/folded scalar indicators (|-, |, >-, >) when they are the entire value after message: - Replace fixed '^ ' continuation check with dynamic indentation-depth comparison so continuation lines (deeper indent than message: key) are correctly collected while sibling keys like severity: are excluded Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com> Agent-Logs-Url: https://github.com/DataScience4Psych/actions/sessions/71658e60-8cda-4f29-bf56-aa97015ea3ec
Copilot
AI
changed the title
[WIP] Revert fix info parameter not appearing in autograding failure messages
Fix multi-line TAP failure messages truncated by over-eager trimws()
Mar 23, 2026
smasongarrison
changed the base branch from
revert-18-copilot/add-info-to-unit-test-feedback
to
main
Member
|
@copilot are you sure that this fixes the main branch? |
Skip empty continuation lines (matching main branch behavior) and use a unified content-first-then-append pattern for both block scalars and inline messages. This makes the implementation produce identical output to main for all |- block scalar cases, while also correctly handling >- folded scalars (which main did not recognize). Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com> Agent-Logs-Url: https://github.com/DataScience4Psych/actions/sessions/c6fdd31e-b2c5-4ce2-acf4-815d4505d692
Contributor
Author
Yes, confirmed. I compared the PR implementation against the The net diff from Fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trimws()in the TAP parsing loop strips leading whitespace frommsg_lines, making the continuation-line detectiongrepl('^ ', ...)dead codemsg_lines, update pattern matching to handle indented lines, use indentation-depth comparison for continuation detection|-,|,>-,>) when they are the entire value aftermessage:>-folded scalars correctly where main did not⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.