test(cloud): add staging smoke test for recce-cloud upload#1114
Open
test(cloud): add staging smoke test for recce-cloud upload#1114
Conversation
E2E test covering GitHub and RECCE_API_TOKEN upload flows against the staging server. Uses static dbt fixtures (no dbt build needed) and a cleanup trap to delete PR sessions after each run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: even-wei <evenwei@infuseai.io>
The recce state download/upload/purge tests are no longer needed — state file workflows are separate from the artifact pipeline tested here. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: even-wei <evenwei@infuseai.io>
Remove SMOKE_TEST_GITHUB_REPO secret in favor of hardcoded repo name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: even-wei <evenwei@infuseai.io>
Tests 5-6 cover the --session-name (dev session) and --session-id upload flows. Test 6 reuses the session created by test 5. Both require SMOKE_TEST_API_TOKEN + SMOKE_TEST_ORG + SMOKE_TEST_PROJECT. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: even-wei <evenwei@infuseai.io>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: even-wei <evenwei@infuseai.io>
uv sync at the repo root doesn't install the recce_cloud workspace member's entry point. Install from recce_cloud/ like tests-recce-cloud workflow does. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: even-wei <evenwei@infuseai.io>
Match the pattern from tests-recce-cloud.yaml — let uv manage the venv and PATH instead of manually activating. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: even-wei <evenwei@infuseai.io>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: even-wei <evenwei@infuseai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
Test / CI
What this PR does / why we need it:
Adds an E2E smoke test for
recce-cloud uploadagainst the staging server, covering all testable authentication flows:GITHUB_TOKEN→ platform-specific endpointGITHUB_TOKEN+--type prodRECCE_API_TOKEN→ generic endpointRECCE_API_TOKEN+--type prodKey design decisions:
dbt buildneeded (server stores files as-is)env -u RECCE_API_TOKENfor GitHub flow isolation (CLI Priority 1 = API token)SMOKE_TEST_API_TOKENnot setAlso removes the obsolete Recce State file operations (
download/purge/upload) from the existing dbt cloud smoke test.Secrets required
RECCE_CLOUD_TOKENSMOKE_TEST_GITHUB_REPOSMOKE_TEST_API_TOKENWhich issue(s) this PR fixes:
N/A — new test coverage
Special notes for your reviewer:
The workflow triggers on changes to
recce_cloud/**andintegration_tests/recce_cloud/**. It will not run untilSMOKE_TEST_GITHUB_REPOis added as a repository secret.Does this PR introduce a user-facing change?:
NONE