[EXPERIMENTAL] feat(golang): single source of truth for Go versions via dd-trace-go go-versions.yml#6350
Draft
[EXPERIMENTAL] feat(golang): single source of truth for Go versions via dd-trace-go go-versions.yml#6350
Conversation
kakkoyun
added a commit
to DataDog/dd-trace-go
that referenced
this pull request
Feb 19, 2026
…g build Read the stable Go version from the local go-versions.yml (checked out at binaries/dd-trace-go) and pass it as GO_VERSION to build.sh, which forwards it as --build-arg GO_VERSION to docker buildx build. This wires dd-trace-go's single source of truth into the system-tests weblog Docker build, so Go version bumps in go-versions.yml automatically propagate to the container image without a manual PR. Companion PR: DataDog/system-tests#6350 Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
9 tasks
72279d8 to
0c6d308
Compare
Contributor
|
|
|
✨ Fix all issues with BitsAI or with Cursor
|
Add a composite action that fetches go-versions.yml from DataDog/dd-trace-go
main branch, and wire the stable Go version through build.sh into all 10 Go
weblog Dockerfiles via ARG GO_VERSION. Each Dockerfile also runs
`go mod edit -go=${GO_VERSION}` at build time so the language directive in
go.mod stays in sync with the base image.
This eliminates manual Go version bump PRs — system-tests CI derives the
version from dd-trace-go's single source of truth on every build.
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
0c6d308 to
acf57ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dd-trace-go/go-versions.ymlis the single source of truth for Go versions.system-testsstill hardcodesgolang:1.24across 10 Dockerfiles, requiring a manual PR on every Go version bump (e.g. #6277).This PR makes those manual PRs unnecessary.
Changes
.github/actions/go-versions/action.yml— composite action that fetchesgo-versions.ymlfromDataDog/dd-trace-go/mainvia HTTPS and exportsstable,oldstable,stable_patch,oldstable_patchas step outputs.ARG GO_VERSION=1.26beforeFROM. Each Dockerfile re-declaresARG GO_VERSIONinside its build stage and runsgo mod edit -go=${GO_VERSION}to keep the go.mod language directive in sync at build time.utils/build/build.sh— forwardsGO_VERSIONenv var as--build-arg GO_VERSION=...todocker buildx build. No-op whenGO_VERSIONis unset (other languages unaffected).system-tests.yml+run-end-to-end.yml— add a "Fetch Go versions" step (skipped for non-golang libraries) before the weblog build, passingGO_VERSIONas an env var.Companion PR in dd-trace-go wires the local
go-versions.ymlinto its own system-tests workflow.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present