Skip to content

Comments

chore: add supported-configurations v2#3621

Merged
bwoebi merged 19 commits intomasterfrom
BridgeAR/2026-02-04-add-supported-configuration-v2
Feb 21, 2026
Merged

chore: add supported-configurations v2#3621
bwoebi merged 19 commits intomasterfrom
BridgeAR/2026-02-04-add-supported-configuration-v2

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Feb 4, 2026

This adds the supported-configurations.json to php. That file is auto generated from configuration.h. As long as they are in sync, things will work easily. The validation step verifies in the CI if the file got updated or not and would fail, if a change was added without committing.

The one pipeline CI checks are added as well to make sure new configurations are added to the central repository before the PR that adds the config lands.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 4, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1028 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 699900800000000020ccb1fb134df31c
tid: 6999008000000000
hexProcessTraceId: 20ccb1fb134df31c
hexProcessSpanId: 9c4aca11b69fd7d1
processTraceId: 2363459596381451036
processSpanId: 11262035995620530129
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f181006 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.17%. Comparing base (b29a3e6) to head (f181006).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3621      +/-   ##
==========================================
+ Coverage   62.11%   62.17%   +0.06%     
==========================================
  Files         141      141              
  Lines       13388    13352      -36     
  Branches     1753     1746       -7     
==========================================
- Hits         8316     8302      -14     
+ Misses       4273     4259      -14     
+ Partials      799      791       -8     
Files with missing lines Coverage Δ
appsec/src/extension/configuration.c 69.56% <ø> (-0.64%) ⬇️
appsec/src/extension/configuration.h 100.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a3e6...f181006. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR BridgeAR marked this pull request as ready for review February 4, 2026 21:57
@BridgeAR BridgeAR requested a review from a team as a code owner February 4, 2026 21:57
@BridgeAR BridgeAR requested review from bwoebi and genesor February 4, 2026 21:57
@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-02-21 01:54:59

Comparing candidate commit f181006 in PR branch BridgeAR/2026-02-04-add-supported-configuration-v2 with baseline commit b29a3e6 in branch master.

Found 4 performance improvements and 4 performance regressions! Performance is the same for 184 metrics, 2 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟩 execution_time [-1393.247ns; -406.753ns] or [-11.420%; -3.334%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-8.584µs; -6.836µs] or [-7.771%; -6.188%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-10.367µs; -8.613µs] or [-9.305%; -7.731%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+59.018ns; +123.782ns] or [+5.055%; +10.602%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+107.532ns; +156.668ns] or [+9.263%; +13.495%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+97.746ns; +162.854ns] or [+8.427%; +14.040%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+103.498ns; +157.102ns] or [+8.933%; +13.560%]

scenario:TraceSerializationBench/benchSerializeTrace-opcache

  • 🟩 execution_time [-15.234µs; -8.066µs] or [-4.378%; -2.318%]

@genesor genesor requested a review from a team as a code owner February 12, 2026 13:46
@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2026

Benchmarks [ appsec ]

Benchmark execution time: 2026-02-21 01:16:38

Comparing candidate commit f181006 in PR branch BridgeAR/2026-02-04-add-supported-configuration-v2 with baseline commit b29a3e6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@BridgeAR BridgeAR force-pushed the BridgeAR/2026-02-04-add-supported-configuration-v2 branch from 64bcaec to 0974e5d Compare February 19, 2026 13:59
@BridgeAR BridgeAR requested review from a team as code owners February 19, 2026 13:59
@BridgeAR BridgeAR force-pushed the BridgeAR/2026-02-04-add-supported-configuration-v2 branch from 0974e5d to 71ab2ae Compare February 19, 2026 14:03
BridgeAR and others added 15 commits February 21, 2026 01:36
This adds the supported-configurations.json to php. That file is
auto generated from configuration.h. As long as they are in sync,
things will work easily. The validation step verifies in the CI
if the file got updated or not and would fail, if a change was
added without committing.

The one pipeline CI checks are added as well to make sure new
configurations are added to the central repository before the PR
that adds the config lands.
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the BridgeAR/2026-02-04-add-supported-configuration-v2 branch from 7df01ed to f181006 Compare February 21, 2026 00:37
@bwoebi bwoebi merged commit a3409cd into master Feb 21, 2026
2049 of 2072 checks passed
@bwoebi bwoebi deleted the BridgeAR/2026-02-04-add-supported-configuration-v2 branch February 21, 2026 02:13
@github-actions github-actions bot added this to the 1.17.0 milestone Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants