Skip to content

[Fix] Force resolution of androidx.core to 1.13.1#1221

Merged
sbarrio merged 1 commit intodevelopfrom
sbarrio/fix/force-resolution-androidx.core-ktx-on-rn-76-and-below
Mar 24, 2026
Merged

[Fix] Force resolution of androidx.core to 1.13.1#1221
sbarrio merged 1 commit intodevelopfrom
sbarrio/fix/force-resolution-androidx.core-ktx-on-rn-76-and-below

Conversation

@sbarrio
Copy link
Contributor

@sbarrio sbarrio commented Mar 23, 2026

What does this PR do?

With the recent bump of the Datadog Android SDK to 3.8.0, the androidx.core:core: and 'androidx.core:core-ktx where bumped to 1.15.0, which require compileSdk=35. Since React native below 0.76 uses compileSdk=34 this breaks the app build hosting the SDK.

This PR forces the resolution to the previous, and last compatible version with compileSdk=34, which is 1.13.1.

Motivation

The SDK should not break host app builds.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio marked this pull request as ready for review March 23, 2026 19:15
@sbarrio sbarrio requested a review from a team as a code owner March 23, 2026 19:15
Copilot AI review requested due to automatic review settings March 23, 2026 19:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to keep host apps on React Native < 0.76 (compileSdk 34) building after the Datadog Android SDK bump to 3.8.0, by preventing androidx.core from resolving to versions that require compileSdk 35.

Changes:

  • Add a Gradle resolution strategy intended to force androidx.core:core and androidx.core:core-ktx to 1.13.1 for RN < 0.76 builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sbarrio sbarrio force-pushed the sbarrio/fix/force-resolution-androidx.core-ktx-on-rn-76-and-below branch from 2ca9547 to b23a332 Compare March 23, 2026 19:27
@sbarrio sbarrio merged commit a62bbed into develop Mar 24, 2026
11 checks passed
@sbarrio sbarrio deleted the sbarrio/fix/force-resolution-androidx.core-ktx-on-rn-76-and-below branch March 24, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants