⚗ NextJS- add nextjs error boundary component by BeltranBulbarellaDD · Pull Request #4352 · DataDog/browser-sdk

BeltranBulbarellaDD · 2026-03-17T15:27:58Z

Motivation

Adds React error boundary to NextJS pages router.

Changes

Adds ErrorBoundary — a React error boundary component that wraps createErrorBoundary from @datadog/browser-rum-react, pre-wired to call addNextjsError.

Exports ErrorBoundaryFallback and ErrorBoundaryProps types alongside it.

Also adds @datadog/browser-rum-react as an optional peer dependency of rum-nextjs, and allows @datadog/browser-rum-react/internal through the disallow-side-effects ESLint rule.

Test instructions

Test app — new pages for both routers to exercise all error paths:

Scenario	Implementation
Pages Router client error	ErrorBoundary in `pages-router/error-test.tsx`
App Router client error	`error.tsx` segment boundary calling `addNextjsError`
App Router server error (with digest)	Server component throw → `error.tsx` calling `addNextjsError`
App Router global error	Root-level throw → `global-error.tsx` calling `addNextjsError`

Checklist

Tested locally
Tested on staging
Added unit tests for this change.
Added e2e/integration tests for this change.
Updated documentation and/or relevant AGENTS.md file

datadog-official · 2026-03-17T15:31:11Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 77.26% (+0.00%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 9254f01 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!}

cit-pr-commenter-54b7da · 2026-03-17T15:32:26Z

Bundles Sizes Evolution

📦 Bundle Name	Base Size	Local Size	𝚫%	Status
Rum	175.02 KiB	175.02 KiB	0.00%	✅
Rum Profiler	6.16 KiB	6.16 KiB	0.00%	✅
Rum Recorder	27.46 KiB	27.46 KiB	0.00%	✅
Logs	56.80 KiB	56.80 KiB	0.00%	✅
Rum Slim	130.66 KiB	130.66 KiB	0.00%	✅
Worker	23.63 KiB	23.63 KiB	0.00%	✅

🚀 CPU Performance

Action Name	Base CPU Time (ms)	Local CPU Time (ms)	𝚫%
RUM - add global context	0.004	0.005	+25.00%
RUM - add action	0.0134	0.015	+11.94%
RUM - add error	0.0127	0.0161	+26.77%
RUM - add timing	0.0025	0.003	+20.00%
RUM - start view	0.012	0.0129	+7.50%
RUM - start/stop session replay recording	0.0006	0.0008	+33.33%
Logs - log message	0.0143	0.0174	+21.68%

🧠 Memory Performance

Action Name	Base Memory Consumption	Local Memory Consumption	𝚫
RUM - add global context	25.69 KiB	25.78 KiB	+98 B
RUM - add action	51.26 KiB	51.22 KiB	-42 B
RUM - add timing	27.36 KiB	27.70 KiB	+346 B
RUM - add error	56.07 KiB	53.71 KiB	-2.36 KiB
RUM - start/stop session replay recording	25.97 KiB	26.18 KiB	+225 B
RUM - start view	467.22 KiB	462.01 KiB	-5.21 KiB
Logs - log message	45.41 KiB	45.09 KiB	-333 B

🔗 RealWorld

BeltranBulbarellaDD · 2026-03-17T16:08:59Z

packages/rum-nextjs/src/domain/error/errorBoundary.spec.tsx

Since all these tests are the same for rum-react (except for the last one) should I remove them?

BeltranBulbarellaDD · 2026-03-17T16:09:57Z

package.json

    "build:docs:json": "typedoc --logLevel Verbose --json ./docs.json",
    "build:docs:html": "typedoc --out ./docs",
-    "pack": "yarn workspaces foreach --all --parallel --include '@datadog/*' exec yarn pack",
+    "pack": "yarn workspaces foreach --all --parallel --topological --include '@datadog/*' exec yarn pack",


This is required because rum-nextjs needs rum-react

I'm not sure about this... rum depends on rum-code which depends on core and that was not an issue before.

Hm let's discuss!

Discussed here

BeltranBulbarellaDD · 2026-03-17T16:21:24Z

test/e2e/playwright.base.config.ts

      stdout: 'pipe' as const,
      cwd: path.join(__dirname, '../apps/nextjs'),
-      command: isLocal ? 'yarn dev' : 'yarn start',
+      command: 'yarn start',


This is for 2 reasons:

So that StrictMode does not double-fires in dev mode.

The dev error overlay does not appear (ex)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d7f0239ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/rum-nextjs/src/entries/main.ts

BenoitZugmeyer · 2026-03-18T20:06:50Z

package.json

    "build:docs:json": "typedoc --logLevel Verbose --json ./docs.json",
    "build:docs:html": "typedoc --out ./docs",
-    "pack": "yarn workspaces foreach --all --parallel --include '@datadog/*' exec yarn pack",
+    "pack": "yarn workspaces foreach --all --parallel --topological --include '@datadog/*' exec yarn pack",


I'm not sure about this... rum depends on rum-code which depends on core and that was not an issue before.

BenoitZugmeyer · 2026-03-18T20:09:38Z

test/e2e/scenario/nextjsPlugin.scenario.ts

+            expect(customErrors[0].context).toMatchObject({
+              framework: 'nextjs',
+              nextjs: { digest: expect.any(String) },
+            })


suggestion:

expect(errorEvent.error.component_stack).toBeDefined()

But we are not testing the same thing right? I don't mind the change I just wanted to test the nextjs specific values.

packages/rum-react/internal.d.ts

packages/rum-nextjs/package.json

.claude/skills/datadog-sdk-event-inspection/SKILL.md

… boundary

BeltranBulbarellaDD added 2 commits March 17, 2026 15:26

Add error boundary to Rum-Nextjs

fda52cb

Add e2e tests

48f6769

BeltranBulbarellaDD added 2 commits March 17, 2026 16:42

Disallow side effect from React, CI fixes

3cf211b

fix rum-react version

e0d3dee

BeltranBulbarellaDD commented Mar 17, 2026

View reviewed changes

Remove import

cd405c3

BeltranBulbarellaDD changed the title ~~Beltran.bulbarella/nextjs pages router error~~ ✨ NextJS- add nextjs error boundary component Mar 17, 2026

BeltranBulbarellaDD added 5 commits March 17, 2026 18:16

Add error boundary to Rum-Nextjs

f4aedea

build

676d170

add skill

bb905f7

Fix tests

c7e7ca7

format

6d7f023

BeltranBulbarellaDD marked this pull request as ready for review March 18, 2026 20:01

BeltranBulbarellaDD requested a review from a team as a code owner March 18, 2026 20:01

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

packages/rum-nextjs/src/entries/main.ts Show resolved Hide resolved

BenoitZugmeyer reviewed Mar 18, 2026

View reviewed changes

thomas-lebeau reviewed Mar 19, 2026

View reviewed changes

.claude/skills/datadog-sdk-event-inspection/SKILL.md Outdated Show resolved Hide resolved

BeltranBulbarellaDD added 2 commits March 19, 2026 14:15

Remove internal file, add firefox timeout, update nextjs dependencies.

818eab3

Remove unused file

58eb95b

BeltranBulbarellaDD changed the title ~~✨ NextJS- add nextjs error boundary component~~ ⚗ NextJS- add nextjs error boundary component Mar 20, 2026

BeltranBulbarellaDD added 2 commits March 20, 2026 13:43

Skip Firefox test on pages router error, add internal types for error…

3cb098b

… boundary

Prevent duplicate error name

9254f01

Conversation

BeltranBulbarellaDD commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Test instructions

Checklist

Uh oh!

datadog-official bot commented Mar 17, 2026 • edited by datadog-prod-us1-3 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cit-pr-commenter-54b7da bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundles Sizes Evolution

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BeltranBulbarellaDD Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BeltranBulbarellaDD commented Mar 17, 2026 •

edited

Loading

datadog-official bot commented Mar 17, 2026 •

edited by datadog-prod-us1-3 bot

Loading

cit-pr-commenter-54b7da bot commented Mar 17, 2026 •

edited

Loading

BeltranBulbarellaDD Mar 19, 2026 •

edited

Loading