Bugfix: CAD attributes not available to t8_geometry_cad.cxx

[saustinp]

Describe your changes here:
Added private header to src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.cxx. Previously, this file required a public header, t8_geometry_cad.hxx, for T8_CMESH_CAD_EDGE_ATTRIBUTE_KEY and T8_CMESH_CAD_FACE_ATTRIBUTE_KEY. However, the header file transitively included a private header which was not available after building, which broke compilation of programs using this feature, for example t8_features_curved_meshes.cxx.

Now, src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.cxx directly includes the private header file, bypassing t8_geometry_cad.hxx for these attributes. Fixes #2220.

All these boxes must be checked by the AUTHOR before requesting review:

• The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
• The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
• If the PR is related to an issue, make sure to link it.
• The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

• The reviewer executed the new code features at least once and checked the results manually.
• The code follows the t8code coding guidelines.
• New source/header files are properly added to the CMake files.
• The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
• All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

• The code is covered in an existing or new test case using Google Test.
• The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
• Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

• Should this use case be added to the github action?
• If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

• If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
• If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

• The author added a BSD statement to doc/ (or already has one).

[holke]

Thanks 👍

[holke]

The doxygen CI test fails...which looks to me like an issue due to this PR coming from a fork...
We probably can ignore that.

[sandro-elsweijer]

The doxygen CI test fails...which looks to me like an issue due to this PR coming from a fork... We probably can ignore that.

This happens because github does not automatically sync tags between upstream and forked repos. They have to be synced manually. And since our workflow uses the tags to determine the t8code version, it fails.
I wrote a short fix for that:
https://github.com/DLR-AMR/t8code/wiki/Contribution-Workflow#failing-version-tags-in-pr-tests

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.27%. Comparing base (4a737b6) to head (9c3a140).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2223   +/-   ##
=======================================
  Coverage   78.27%   78.27%           
=======================================
  Files         114      114           
  Lines       19101    19101           
=======================================
  Hits        14952    14952           
  Misses       4149     4149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.