Draft
Conversation
| observation: PointObservation | TrackObservation | VerticalObservation, | ||
| spatial_method: Optional[str] = None, | ||
| ) -> PointModelResult | TrackModelResult: ... | ||
| ) -> PointModelResult | TrackModelResult | VerticalModelResult: ... |
|
|
||
| def _extract_vertical_column( | ||
| self, observation: VerticalObservation, spatial_method: Optional[str] = None | ||
| ) -> VerticalModelResult: ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #596
Step 2 of 4 in implementation of vertical skills
General idea of vertical skill is to store data for model and obs in 1d (see below). Depth information is stored in auxilary coordinate z. Befinit of this compared to storing in 2d:
Steps:
Features added in this PR
Support vertical obs per commit
(see vertical skill notebook for more info)
VerticalObservation class
Stores timeseries data for vertical profiles.
Validate timeseries with geomtype=vertical.
parse input for timeseries with vertical coordinate.
Very similar to parsing of tracks (_track.py) but z-coordinate is now needed.
data structure:
time(time) = [t1, t1, t1, t2, t2, t2, t3 ...]
z(time) = [z1. z2, z3, z4, z5, z6, z7 ...]
data(time) = [d1, d2, d3, d4,d5,d6,d7....]
Testdata
Tests of new features