Draft
Conversation
ecomodeller
approved these changes
Feb 19, 2026
Member
ecomodeller
left a comment
ecomodeller
left a comment
There was a problem hiding this comment.
Great summary.
Nice to have some plots to use as inspiration.
* Adds vertical geometry type * Adds additional check for zcoord if gtype is vertical
Very similar to parsing of tracks (_track.py) but z-coordinate is now needed. * remove duplicated (time,z) pairs. Note, duplicated time allowed ( obs with same time on multiple depth)
Stores timeseries data for vertical profiles. data structure time(time) = [t1, t1, t1, t2, t2, t2, t3 ...] z(time) = [z1. z2, z3, z4, z5, z6, z7 ...] data(time) = [d1, d2, d3, d4,d5,d6,d7....]
Add support for vertical obs
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| fn = Path("tests/testdata/vertical/VerticalProfile_ST.dfs0") | ||
| # no item specified, but multiple items in file | ||
| with pytest.raises(ValueError): | ||
| obs = ms.observation(fn, z_item="z") |
| index=[pd.Timestamp("2019-01-01")] * 3, | ||
| ) | ||
| with pytest.warns(UserWarning, match="Removed 1 duplicate"): | ||
| obs = ms.VerticalObservation( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See vertical_skill notebook for plots examples, implementation ideas etc.
Summary of qustionnaire ~40 answers
What does this mean for Modelskill dev:
Features needed for minimal version