Allows tick events to auto-requeue when registered as listeners#2484
Allows tick events to auto-requeue when registered as listeners#2484cppcooper wants to merge 5 commits intoDFHack:developfrom
Conversation
myk002
left a comment
There was a problem hiding this comment.
after this change, what will the options be for cpp and lua code to handle regular callbacks? will we be able to replace repeat-util with eventful?
It looks as though that script could easily be replaced, yes. edit: As for options, cpp will have the eventful on the other hand, doesn't have tick events integrated.. but shouldn't be difficult to do. edit2: So I've tried to integrate tick events to eventful. It needs a bit of testing, but I believe it has all the same boilerplate the other event types have (so it should work, unless I missed something). It will only rely on the |
ca0ebb9 to
372c345
Compare
- converts `freq` and `eventHandler` (i.e. the callback) to `const` - removes the non-const `when` from the hash computation
1a4914b to
e2bc986
Compare
As discussed on discord, there are a few technical challenges when bringing tick events to lua. So I reverted those changes. I've included an updated channel-safely in this PR which uses the newly repeating tick events to perform some tasks. Additionally I had added a temporary event which repeated hourly and performed a test to ensure the tick listener events are refiring without any user effort. [test was successful] |
No description provided.