Add negative game tests for all advancements#59
Merged
rubensworks merged 2 commits intomaster-1.21-ltsfrom Feb 28, 2026
Merged
Conversation
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add negative game tests for all advancements in the mod
Add negative game tests for all advancements
Feb 28, 2026
Pull Request Test Coverage Report for Build 22526178543Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advancements can silently break when predicate field names change (e.g.
"item"→"items"in MC 1.21), causing false-positive triggers. Negative tests catch these regressions.Changes
assertAdvancementNotDonehelper — symmetric counterpart toassertAdvancementDone; uses an explicit null guard before asserting progress is not completetestAdvancementRootNegativeintegrateddynamics:variable)testAdvancementMendesiteNegativeintegratedscripting:mendesite)testAdvancementScriptingDiskNegativescripting_disk)testAdvancementScriptingDriveNegativescripting_disk(notscripting_drive)testAdvancementTerminalOpenNegativeContainerTerminalScripting)testAdvancementTerminalBindNegativeBlocks.STONE, notpart_terminal_scripting)testAdvancementTerminalDisplayNegativetestAdvancementFilterChestNegativeoperator_filterwith two aspect inputs —input[0]is aspect, not script💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.