Skip to content

fix: concoredocker API methods were private, class was uncallable from outside #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pradeeban merged 1 commit into from
Feb 26, 2026
Merged

fix: concoredocker API methods were private, class was uncallable from outside #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions concoredocker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ private static Map<String, Object> parseFile(String filename) throws IOException
* Sets maxtime from concore.maxtime file, or uses defaultValue if file not found.
* Catches both IOException and RuntimeException to match Python safe_literal_eval.
*/
private static void defaultMaxTime(double defaultValue) {
public static void defaultMaxTime(double defaultValue) {
try {
String content = new String(Files.readAllBytes(Paths.get(inpath + "/1/concore.maxtime")));
Object parsed = literalEval(content.trim());
Expand All @@ -126,7 +126,7 @@ private static void defaultMaxTime(double defaultValue) {
}
}

private static boolean unchanged() {
public static boolean unchanged() {
if (olds.equals(s)) {
s = "";
return true;
Expand All @@ -135,7 +135,7 @@ private static boolean unchanged() {
return false;
}

private static Object tryParam(String n, Object i) {
public static Object tryParam(String n, Object i) {
if (params.containsKey(n)) {
return params.get(n);
} else {
Expand All @@ -149,7 +149,7 @@ private static Object tryParam(String n, Object i) {
* Returns: list of values after simtime
* Includes max retry limit to avoid infinite blocking (matches Python behavior).
*/
private static List<Object> read(int port, String name, String initstr) {
public static List<Object> read(int port, String name, String initstr) {
// Parse default value upfront for consistent return type
List<Object> defaultVal = new ArrayList<>();
try {
Expand Down Expand Up @@ -275,7 +275,7 @@ private static String toPythonLiteral(Object obj) {
* Prepends simtime+delta to the value list, then serializes to Python-literal format.
* Accepts List or String values (matching Python implementation).
*/
private static void write(int port, String name, Object val, int delta) {
public static void write(int port, String name, Object val, int delta) {
try {
String path = outpath + "/" + port + "/" + name;
StringBuilder content = new StringBuilder();
Expand Down Expand Up @@ -322,7 +322,7 @@ private static void write(int port, String name, Object val, int delta) {
* Parses an initial value string like "[0.0, 1.0, 2.0]".
* Extracts simtime from position 0 and returns the remaining values as a List.
*/
private static List<Object> initVal(String simtimeVal) {
public static List<Object> initVal(String simtimeVal) {
List<Object> val = new ArrayList<>();
try {
List<?> inval = (List<?>) literalEval(simtimeVal);
Expand Down