fix(ci): add ruff.toml, format check, coverage, merge tests.yml#461
Open
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Open
fix(ci): add ruff.toml, format check, coverage, merge tests.yml#461avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Conversation
1be45da to
72f3653
Compare
Author
|
Hey @pradeeban @Rahuljagwani, quick update based on your note about avoiding core modules. I’ve excluded the core Python modules from ruff (both lint and format), so CI won’t touch them. Bare-except fixes are scoped to CLI command files only, nothing in core python classes. Remaining diff is CI wiring plus format cleanup in CLI/tests, which should be safer to review. Also once this lands, legacy dirs (0mq/, ratc/, demo/ etc.) are still excluded from ruff. Happy to open a follow-up issue to track that cleanup incrementally when you think it's the right time. lmk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff was only checking syntax errors, format was never checked, coverage was installed but never used, and we had two workflows with different dep installs both running pytest. fixed.
Fixes #454