fix: keyboard nav, aria-labels, replace native confirm dialogs#346
Open
avinxshKD wants to merge 2 commits intoControlCore-Project:devfrom
Open
fix: keyboard nav, aria-labels, replace native confirm dialogs#346avinxshKD wants to merge 2 commits intoControlCore-Project:devfrom
avinxshKD wants to merge 2 commits intoControlCore-Project:devfrom
Conversation
Author
|
@pradeeban quick note: I intentionally removed confirm from forcePullFromServer instead of re-adding it via modal. it’s only hit programmatically (init / empty action history), and prompting there felt noisy and brittle. if you want strict parity, I can wire the same app modal back in there. Please lmk thanks, goodnight :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #343
went through the keyboard/SR pass mentioned in the issue. kept it tight... behavior first, then labels, no broad refactor.
SET_CONFIRM_MODAL in reducer holds { open, message, onConfirm }, graph-core classes dispatch it, GraphWorkspace renders the single global ConfirmModal and calls onConfirm on confirm. everything else is one-liners.