fix: add error boundary, safe base64 encoding, and proper fetch error handling#344
Open
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Open
fix: add error boundary, safe base64 encoding, and proper fetch error handling#344avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Conversation
Author
|
@pradeeban fixing this was a bit weird to debug because btoa and fetch reject paths were failing in non-obvious ways, but should be stable now. btoa was the main footgun here (emoji labels could silently break autosave), fetch rejects were passing unresolved bodies so catches got useless errors, and root boundary now prevents full white-screen crashes... happy to scope the boundary lower if you prefer lmk thanks |
Author
|
Also i tried to keep it as minimal i can, and stay within scope, still learning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes #342, error boundary at root so crashes dont white screen, switched btoa to TextEncoder so emoji labels dont break autosave, fixed fetch rejects that were passing a promise instead of a string so catch blocks were getting